[Pan-devel] crash reading article with non-ascii subject (patch)

[Christophe Lambin]

I encountered a crash in gui/body-pane.cc:XXX when reading an article
with a non-ascii subject. The following patch fixes that crash:

--- pan-0.92/pan/gui/body-pane.cc       2006-04-09 03:02:09.000000000
+0200
+++ pan-0.92-mine/pan/gui/body-pane.cc  2006-04-11 23:37:34.000000000
+0200
@@ -674,7 +674,7 @@
     char * utf8_val (header_to_utf8 (val, fallback_charset));
     char * e (0);
     if (strcmp (key, "From"))
-      e = g_markup_printf_escaped ("<span weight=\"bold\">%s</span>", val);
+      e = g_markup_printf_escaped ("<span weight=\"bold\">%s</span>", 
utf8_val);
     else {
       const StringView v = GNKSA :: get_short_author_name (utf8_val);
       e = g_markup_printf_escaped ("<span weight=\"bold\">%s</span>", 
v.to_string().c_str());


Also, while looking at this, I noticed that Pan is still quite
unforgiving with incorrect quote-printable encoded headers. Example:

        Belgi=?ISO-8859-1?B?6w==?=

This is obviously incorrect, but wasn't gmime 2.0 supposed to support these ?

Regards,
Christophe

pgpjrSw7AzTOg.pgp
Description: PGP signature