[paparazzi-commits] [paparazzi/paparazzi] dbff73: Some minor improvements and probably the last ones...

[hendrixgr]

  Branch: refs/heads/master
  Home:   https://github.com/paparazzi/paparazzi
  Commit: dbff73a0543ba8de2c6bab63dab5d55ea64663ce
      
https://github.com/paparazzi/paparazzi/commit/dbff73a0543ba8de2c6bab63dab5d55ea64663ce
  Author: hendrixgr <hendrixgr@gmail.com>
  Date:   2020-10-15 (Thu, 15 Oct 2020)

  Changed paths:
    M conf/modules/board_matek_wing.xml
    M sw/airborne/modules/display/max7456.c
    M sw/airborne/modules/display/max7456_regs.h

  Log Message:
  -----------
  Some minor improvements and probably the last ones. (#2602)

* removed "MAX7456_SLAVE_IDX" redefined warnings

 changed <define name="MAX7456_SPI_DEV" value="spi2" /> AND  <define 
name="MAX7456_SLAVE_IDX" value="SPI_SLAVE1" />
to  <configure name="MAX7456_SPI_DEV" value="spi2" /> AND  <configure 
name="MAX7456_SLAVE_IDX" value="SPI_SLAVE1" />
otherwise i was getting to many warnings about "MAX7456_SLAVE_IDX" redefined

* improved osd busy flag checks

Removed one static function and the code now checks both the OSD busy flag and 
the OSD Reset flag.

* Added THE OSD status register bits

Added two more definitions about the OSD busy flag and the OSD reset flag.

* Made the busy flag check a litle more strict.

Removed one static function and the code now checks both the OSD busy flag and 
the OSD Reset flag.

* Changed the busy flag check

Removed one static function and the code now checks both the OSD busy flag and 
the OSD Reset flag always after writing to the OSD
The code is also a bit cleaner.

* changed the OSD STATUS register bit positions 

I changed the OSD status register bit positions and names to better blend with 
the rest of the file.
They weren't used anywhere else except for the busy flag checks.

* STATUS register bit position names and style change

I changed the OSD status register bit positions and names to better blend with 
the rest of the file and to look better to the eye.
Those and the older ones are only used to check the busy flag.

* Made the BUSY flag check more robust.

The busy flag (actually the NVRAM Busy FLAG) and the Power On Reset flag now is 
checked every time the code writes something to NVRAM.

* Delete max7456.c