[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [paragui-users] PG_FileArchive patch
From: |
Andrew Ford |
Subject: |
Re: [paragui-users] PG_FileArchive patch |
Date: |
Mon, 27 May 2002 12:36:48 -0700 (PDT) |
Well, that's what I was thinking about, except that
does a full copy of the vector and all the strings. I
didn't know if you wanted that performance hit. For
most applications that will be just fine. It would be
even better to reference count it, but copying should
be fine. I wouldn't bother to add both, though, if
they need to avoid the copy, let them use the existing
functions.
Did you get your copy of modern C++ design yet?
Andrew.
--- Alexander Pipelka <address@hidden> wrote:
> Am Mon, 2002-05-27 um 21.20 schrieb Andrew Ford:
> > I would, except that I just moved cities
> > (unexpectedly) and my computer is 2000km away. I
> > didn't have access to cvs at the time I made the
> patch
> > either, so this is the best I could do for you,
> sorry
> > dude.
>
> Well. Ok.
> Is it a problem for you if i change the return types
> to:
> "std::vector< std::string > &" ?
>
> I would like that much more than dynamically
> creating the vector object.
> Maybe both implementations should be added ?
>
> Alex
>
> >
> > Andrew
> >
> > --- Alexander Pipelka <address@hidden> wrote:
> > > Am Mit, 2002-05-08 um 05.05 schrieb Andrew Ford:
> > > > I wonder if I can sneak this into 1.0.2?
> > > > This is the patch we were talking about a
> couple
> > > of
> > > > weeks ago. It adds the functions:
> > > >
> > > > vector< string > *PG_FileArchive::GetFileList(
> > > const
> > > > char *dir );
> > > >
> > > > and,
> > > >
> > > > vector< string >
> > > *PG_FileArchive::GetSearchPathList();
> > > >
> > > > which should be more convenient to use than
> > > > EnumerateFiles and GetSearchPath, which return
> > > that
> > > > awful NULL-terminated char**
> > >
> > > Would be cool.
> > >
> > > > It isn't a real "patch", just drop the
> > > declarations in
> > > > the header, and the implementations in the
> source.
> > >
> > > > Also included is a little tidbit you can use
> to
> > > test
> > > > it. I've noted what goes where.
> > >
> > > May I ask you to create a real patch ?
> > > Would be *much* easier for me.
> > >
> > > Just in case you forgot:
> > > The current 1.0.2 rc is in the "devel-1-0"
> branch of
> > > the repository.
> > >
> > > Thanks
> > >
> > > Alex
> > >
> > >
> > >
> > >
> > > _______________________________________________
> > > paragui-users mailing list
> > > address@hidden
> > >
> >
>
http://mail.freesoftware.fsf.org/mailman/listinfo/paragui-users
> >
> >
> > __________________________________________________
> > Do You Yahoo!?
> > Yahoo! - Official partner of 2002 FIFA World Cup
> > http://fifaworldcup.yahoo.com
> >
> > _______________________________________________
> > paragui-users mailing list
> > address@hidden
> >
>
http://mail.freesoftware.fsf.org/mailman/listinfo/paragui-users
>
>
>
>
> _______________________________________________
> paragui-users mailing list
> address@hidden
>
http://mail.freesoftware.fsf.org/mailman/listinfo/paragui-users
__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com