[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[pdf-devel] PDF_FORCE_BIGNUM
From: |
Jeffrey Walton |
Subject: |
[pdf-devel] PDF_FORCE_BIGNUM |
Date: |
Thu, 4 Feb 2010 11:53:05 -0500 |
Hi All/Jose,
In config.h near line 790, there's the following comment:
/* Force the usage of the 64bits bignum implementation even if the system
support a suitable native type */
/* #undef PDF_FORCE_BIGNUMS */
I think the comment could be revised to better reflect preprocessor state:
/* Force the usage of the 64bits bignum implementation even if the system
support a suitable native type */
/* #define PDF_FORCE_BIGNUMS */
In addition, types.h has the following comment around line 140:
/* Note that int64_t may be defined by the gnulib stdint.h in
platforms missing that header file. */
#if (defined(HAVE_INT64_T) || defined(int64_t)) && !defined(PDF_FORCE_BIGNUMS)
#define PDF_USE_BUILTIN_64BIT_SUPPORT
#endif
Its not enough to '#define PDF_FORCE_BIGNUMS' in types.h (apparently,
some modules do not treat pdf_i64_t opaquely, or do not honor
PDF_USE_BUILTIN_64BIT_SUPPORT). A more appropriate comment might be:
/* Note that int64_t may be defined by the gnulib stdint.h in
platforms missing that header file. To force use of BIGNUM,
define PDF_FORCE_BIGNUMS in config.h */
#if (defined(HAVE_INT64_T) || defined(int64_t)) && !defined(PDF_FORCE_BIGNUMS)
#define PDF_USE_BUILTIN_64BIT_SUPPORT
#endif
Jeff
- [pdf-devel] PDF_FORCE_BIGNUM,
Jeffrey Walton <=