[PATCH 1/5] Explicitly set completer members of pk_cmd structs to NULL where appropriate.

[John Darrington]

Some of these structs were not fully initialised.  This change fixes that.
---
 ChangeLog     | 10 ++++++++++
 src/pk-def.c  |  4 ++--
 src/pk-help.c |  2 +-
 src/pk-ios.c  |  6 +++---
 src/pk-misc.c |  6 +++---
 src/pk-set.c  | 18 +++++++++---------
 src/pk-vm.c   | 12 ++++++------
 7 files changed, 34 insertions(+), 24 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index ddcf9693..4950997f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2020-02-16  John Darrington <address@hidden>
+
+       * src/pk-def.c: Explicitly set completer member of struct pk_cmd
+       typed variables to NULL.
+        * src/pk-help.c: ditto
+        * src/pk-ios.c:  ditto
+        * src/pk-misc.c: ditto
+        * src/pk-set.c:  ditto
+        * src/pk-vm.c:   ditto
+
 2020-02-19  Jose E. Marchesi  <address@hidden>
 
        * src/pkl-gen.c (pkl_gen_pr_try_until_stmt): Emit sync instruction
diff --git a/src/pk-def.c b/src/pk-def.c
index d09ee66d..b44a801b 100644
--- a/src/pk-def.c
+++ b/src/pk-def.c
@@ -123,8 +123,8 @@ pk_cmd_info_fun (int argc, struct pk_cmd_arg argv[], 
uint64_t uflags)
 
 struct pk_cmd info_var_cmd =
   {"variable", "", "", 0, NULL, pk_cmd_info_var,
-   "info variable"};
+   "info variable", NULL};
 
 struct pk_cmd info_fun_cmd =
   {"function", "", "", 0, NULL, pk_cmd_info_fun,
-   "info funtion"};
+   "info funtion", NULL};
diff --git a/src/pk-help.c b/src/pk-help.c
index 604a6371..ae5cc665 100644
--- a/src/pk-help.c
+++ b/src/pk-help.c
@@ -29,4 +29,4 @@ struct pk_cmd *help_cmds[] =
 struct pk_trie *help_trie;
 
 struct pk_cmd help_cmd =
-  {"help", "", "", 0, &help_trie, NULL, "help COMMAND"};
+  {"help", "", "", 0, &help_trie, NULL, "help COMMAND", NULL};
diff --git a/src/pk-ios.c b/src/pk-ios.c
index 4925687b..afc7d86f 100644
--- a/src/pk-ios.c
+++ b/src/pk-ios.c
@@ -340,19 +340,19 @@ pk_cmd_mem (int argc, struct pk_cmd_arg argv[], uint64_t 
uflags)
 }
 
 struct pk_cmd ios_cmd =
-  {"ios", "t", "", 0, NULL, pk_cmd_ios, "ios #ID"};
+  {"ios", "t", "", 0, NULL, pk_cmd_ios, "ios #ID", NULL};
 
 struct pk_cmd file_cmd =
   {"file", "f", "", 0, NULL, pk_cmd_file, "file FILENAME", 
rl_filename_completion_function};
 
 struct pk_cmd mem_cmd =
-  {"mem", "ts", "", 0, NULL, pk_cmd_mem, "mem NAME"};
+  {"mem", "ts", "", 0, NULL, pk_cmd_mem, "mem NAME", NULL};
 
 struct pk_cmd close_cmd =
   {"close", "?t", "", PK_CMD_F_REQ_IO, NULL, pk_cmd_close, "close [#ID]", 
close_completion_function};
 
 struct pk_cmd info_ios_cmd =
-  {"ios", "", "", 0, NULL, pk_cmd_info_ios, "info ios"};
+  {"ios", "", "", 0, NULL, pk_cmd_info_ios, "info ios", NULL};
 
 struct pk_cmd load_cmd =
   {"load", "f", "", 0, NULL, pk_cmd_load_file, "load FILENAME", 
rl_filename_completion_function};
diff --git a/src/pk-misc.c b/src/pk-misc.c
index fbb8161a..ab14b8ce 100644
--- a/src/pk-misc.c
+++ b/src/pk-misc.c
@@ -93,10 +93,10 @@ pk_cmd_jmd (int argc, struct pk_cmd_arg argv[], uint64_t 
uflags)
 }
 
 struct pk_cmd exit_cmd =
-  {"exit", "?i", "", 0, NULL, pk_cmd_exit, "exit [CODE]"};
+  {"exit", "?i", "", 0, NULL, pk_cmd_exit, "exit [CODE]", NULL};
 
 struct pk_cmd version_cmd =
-  {"version", "", "", 0, NULL, pk_cmd_version, "version"};
+  {"version", "", "", 0, NULL, pk_cmd_version, "version", NULL};
 
 struct pk_cmd jmd_cmd =
-  {"jmd", "", "", 0, NULL, pk_cmd_jmd, "jmd"};
+  {"jmd", "", "", 0, NULL, pk_cmd_jmd, "jmd", NULL};
diff --git a/src/pk-set.c b/src/pk-set.c
index da35436f..2d51b852 100644
--- a/src/pk-set.c
+++ b/src/pk-set.c
@@ -394,33 +394,33 @@ pk_cmd_set_error_on_warning (int argc, struct pk_cmd_arg 
argv[],
 extern struct pk_cmd null_cmd; /* pk-cmd.c  */
 
 struct pk_cmd set_oacutoff_cmd =
-  {"oacutoff", "?i", "", 0, NULL, pk_cmd_set_oacutoff, "set oacutoff 
[CUTOFF]"};
+  {"oacutoff", "?i", "", 0, NULL, pk_cmd_set_oacutoff, "set oacutoff 
[CUTOFF]", NULL};
 
 struct pk_cmd set_oindent_cmd =
-  {"oindent", "?i", "", 0, NULL, pk_cmd_set_oindent, "set oindent [INDENT]"};
+  {"oindent", "?i", "", 0, NULL, pk_cmd_set_oindent, "set oindent [INDENT]", 
NULL};
 
 struct pk_cmd set_odepth_cmd =
-  {"odepth", "?i", "", 0, NULL, pk_cmd_set_odepth, "set odepth [DEPTH]"};
+  {"odepth", "?i", "", 0, NULL, pk_cmd_set_odepth, "set odepth [DEPTH]", NULL};
 
 struct pk_cmd set_omode_cmd =
-  {"omode", "?s", "", 0, NULL, pk_cmd_set_omode, "set omode (normal|tree)"};
+  {"omode", "?s", "", 0, NULL, pk_cmd_set_omode, "set omode (normal|tree)", 
NULL};
 
 struct pk_cmd set_obase_cmd =
-  {"obase", "?i", "", 0, NULL, pk_cmd_set_obase, "set obase (2|8|10|16)"};
+  {"obase", "?i", "", 0, NULL, pk_cmd_set_obase, "set obase (2|8|10|16)", 
NULL};
 
 struct pk_cmd set_endian_cmd =
-  {"endian", "?s", "", 0, NULL, pk_cmd_set_endian, "set endian 
(little|big|host)"};
+  {"endian", "?s", "", 0, NULL, pk_cmd_set_endian, "set endian 
(little|big|host)", NULL};
 
 struct pk_cmd set_nenc_cmd =
-  {"nenc", "?s", "", 0, NULL, pk_cmd_set_nenc, "set nenc (1c|2c)"};
+  {"nenc", "?s", "", 0, NULL, pk_cmd_set_nenc, "set nenc (1c|2c)", NULL};
 
 struct pk_cmd set_pretty_print_cmd =
   {"pretty-print", "s?", "", 0, NULL, pk_cmd_set_pretty_print,
-   "set pretty-print (yes|no)"};
+   "set pretty-print (yes|no)", NULL};
 
 struct pk_cmd set_error_on_warning_cmd =
   {"error-on-warning", "s?", "", 0, NULL, pk_cmd_set_error_on_warning,
-   "set error-on-warning (yes|no)"};
+   "set error-on-warning (yes|no)", NULL};
 
 struct pk_cmd *set_cmds[] =
   {
diff --git a/src/pk-vm.c b/src/pk-vm.c
index fbb5c998..ee16a96c 100644
--- a/src/pk-vm.c
+++ b/src/pk-vm.c
@@ -181,25 +181,25 @@ struct pk_cmd vm_disas_exp_cmd =
   {"expression", "e", PK_VM_DIS_UFLAGS, 0, NULL, pk_cmd_vm_disas_exp,
    "vm disassemble expression[/n] EXP\n\
 Flags:\n\
-  n (do a native disassemble)"};
+  n (do a native disassemble)", NULL};
 
 struct pk_cmd vm_disas_fun_cmd =
   {"function", "s", PK_VM_DIS_UFLAGS, 0, NULL, pk_cmd_vm_disas_fun,
    "vm disassemble function[/n] FUNCTION_NAME\n\
 Flags:\n\
-  n (do a native disassemble)"};
+  n (do a native disassemble)", NULL};
 
 struct pk_cmd vm_disas_map_cmd =
   {"mapper", "e", PK_VM_DIS_UFLAGS, 0, NULL, pk_cmd_vm_disas_map,
    "vm disassemble mapper[/n] EXPRESSION\n\
 Flags:\n\
-  n (do a native disassemble)"};
+  n (do a native disassemble)", NULL};
 
 struct pk_cmd vm_disas_wri_cmd =
   {"writter", "e", PK_VM_DIS_UFLAGS, 0, NULL, pk_cmd_vm_disas_writ,
    "vm disassemble writer[/n] EXPRESSION\n\
 Flags:\n\
-  n (do a native disassemble)"};
+  n (do a native disassemble)", NULL};
 
 struct pk_cmd *vm_disas_cmds[] =
   {
@@ -214,7 +214,7 @@ struct pk_trie *vm_disas_trie;
 
 struct pk_cmd vm_disas_cmd =
   {"disassemble", "e", PK_VM_DIS_UFLAGS, 0, &vm_disas_trie, NULL,
-   "vm disassemble (expression|function)"};
+   "vm disassemble (expression|function)", NULL};
 
 struct pk_cmd *vm_cmds[] =
   {
@@ -225,4 +225,4 @@ struct pk_cmd *vm_cmds[] =
 struct pk_trie *vm_trie;
 
 struct pk_cmd vm_cmd =
-  {"vm", "", "", 0, &vm_trie, NULL, "vm (disassemble)"};
+  {"vm", "", "", 0, &vm_trie, NULL, "vm (disassemble)", NULL};
-- 
2.20.1