Re: [PATCH 4/5] Fix erroneous completer for the .close command

poke-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/5] Fix erroneous completer for the .close command

From:	Jose E. Marchesi
Subject:	Re: [PATCH 4/5] Fix erroneous completer for the .close command
Date:	Fri, 21 Feb 2020 18:58:21 +0100
User-agent:	Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hi John.

    Originally all open io spaces had ids (tags) numbered from zero to N - 1.
    Sometime ago this behaviour was changed, however the completer was not 
updated
    to reflect this.  Consequently the wrong completions were provided.  This 
change
    fixes the completer.

I don't like the idea of exposing the detals of struct ios in ios.h.
Would it be possible to expand the interface with iterators, or
something like that?

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 1/5] Explicitly set completer members of pk_cmd structs to NULL where appropriate., John Darrington, 2020/02/21
- [PATCH 5/5] .ios: Add a completer (same as for the .close command), John Darrington, 2020/02/21
  - Re: [PATCH 5/5] .ios: Add a completer (same as for the .close command), Jose E. Marchesi, 2020/02/21
- [PATCH 3/5] REPL: Fix bug in command line completion., John Darrington, 2020/02/21
  - Re: [PATCH 3/5] REPL: Fix bug in command line completion., Jose E. Marchesi, 2020/02/21
- [PATCH 4/5] Fix erroneous completer for the .close command, John Darrington, 2020/02/21
  - Re: [PATCH 4/5] Fix erroneous completer for the .close command, Jose E. Marchesi <=
    - Re: [PATCH 4/5] Fix erroneous completer for the .close command, John Darrington, 2020/02/21
- [PATCH 2/5] REPL: Use null_completion_function as the default, John Darrington, 2020/02/21
  - Re: [PATCH 2/5] REPL: Use null_completion_function as the default, Jose E. Marchesi, 2020/02/21
- Re: [PATCH 1/5] Explicitly set completer members of pk_cmd structs to NULL where appropriate., Jose E. Marchesi, 2020/02/21

Prev by Date: Re: [PATCH 5/5] .ios: Add a completer (same as for the .close command)
Next by Date: Re: [PATCH] Set the random seed when .jmd is called for the first time
Previous by thread: [PATCH 4/5] Fix erroneous completer for the .close command
Next by thread: Re: [PATCH 4/5] Fix erroneous completer for the .close command
Index(es):
- Date
- Thread