Re: [PATCH 1/2] Add const to buffer param of pkl_parse_buffer

[Tim Rühsen]

On 4/3/20 2:49 PM, Jose E. Marchesi wrote:
> Hi Tim.
>
>
>      2020-04-02 Tim Rühsen  <address@hidden>
>
>              * src/pkl-parser.c (pkl_parse_buffer): Add const to buffer param.
>              * src/pkl-parser.h (pkl_parse_buffer): Likewise.
>
> I just realized this change introduced a warning:
>
> ../../src/pkl-parser.c: In function 'pkl_parse_buffer':
> ../../src/pkl-parser.c:141:10: warning: assignment discards 'const' qualifier 
> from pointer target type [-Wdiscarded-qualifiers]
>       *end = buffer + parser->nchars;

Sorry, easy to miss when I use -Wall -Wextra (I'll propose a fix).
Is there a recommend set of gcc flags to use to be in sync with you ?

Regards, Tim