|
| From: | Tim Rühsen |
| Subject: | Re: [PATCH] Accept %DATADIR% anywhere in data load path |
| Date: | Thu, 9 Apr 2020 12:00:26 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
Amended and pushed. On 4/9/20 11:28 AM, Jose E. Marchesi wrote:
Hi Tim.
+/* Replace all occurrences of 'search' in 'in' by 'replace'.
+ * Return 'in' in case 'search' was not found, else
+ * return a new allocated string with the replaced sequences.
+ * Return NULL on allocation failure.
+ */
Please follow the convention of using caps when referring to function
arguments. For example:
Replace all occurrences of SEARCH in IN by REPLACE.
Other than that, this is OK for master.
Thanks! :)
| [Prev in Thread] | Current Thread | [Next in Thread] |