poke-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Prevent libpoke from linking against libtextstyle

From: Darshit Shah
Subject: Re: [PATCH] Prevent libpoke from linking against libtextstyle
Date: Tue, 5 May 2020 17:29:12 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 


On 5/5/20 5:24 PM, Jose E. Marchesi wrote:


Hi Darshit.

Looks great!  OK for master.

     -  if test $has_hyper_support = yes; then
     -      AC_DEFINE([HAVE_TEXTSTYLE_HYPERLINK_SUPPORT], 1,
     -                [Defined if libtextstyle has support for terminal 
hyperlinks])
     +    AC_DEFINE([HAVE_TEXTSTYLE_HYPERLINK_SUPPORT], 2,
     +              [Defined if libtextstyle has support for terminal 
hyperlinks])
        fi
      ])

I'm curious, why 2 :)
_in case_ in the future we want to differentiate between having real libtextstyle and a gnulib stub. Both continue to work with `#if HAVE_...` and `#ifdef HAVE_...`, but a finer grained control is now possible.
reply via email to
[Prev in Thread] Current Thread [Next in Thread]