[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pickles: Add mbr.pk for MBR partition table
|
From: |
Jose E. Marchesi |
|
Subject: |
Re: [PATCH] pickles: Add mbr.pk for MBR partition table |
|
Date: |
Tue, 26 Jan 2021 11:07:49 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
>> type MBR = struct
>> {
>> byte[440#B] bootstrap;
>> uint32 signature;
>> byte[2] reserved = [0x0UB,0x0UB];
>> MBR_PTE[4] pte;
>> byte[2] magic = [0x55UB,0xaaUB];
>> };
>>
>> Checking that `reserved' is [0x0,0x0] is necessary anyway in this case,
>> isnt it?
>
> I agree with giving it a name.
> And as we discussed in IRC, it seems there's no agreement on the meaning
> of this field so let's declare it without any constraint.
Ok, so given the field name, this is OK for master.
> And I'm happy that I declared it unnamed mistakenly :)
> It revealed a bug!
Indeed :)