[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: build from tarball uses makeinfo
|
From: |
Jose E. Marchesi |
|
Subject: |
Re: build from tarball uses makeinfo |
|
Date: |
Sat, 20 Feb 2021 01:30:32 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> A build of poke-0.90 uses makeinfo:
>
> $ make
> ...
> /bin/bash /media/develdata/devel/build/poke-0.90/build-aux/missing
> makeinfo --plaintext ../../doc/poke.texi \
> > poke.text
> ...
>
> While the GCS allow this (see
> <https://www.gnu.org/prep/standards/html_node/Utilities-in-Makefiles.html>),
> it is a best practice to avoid texinfo as a build prerequisite, by packaging
> the generated files in the tarball. See
> <https://www.gnu.org/prep/standards/html_node/Makefile-Basics.html>
Yeah that was unintended. Didn't think about it when I added the rule
to generate poke.text.
> Here is a proposed fix.
>
> It also replaces a 'clean-local' target with a more declarative
> 'MOSTLYCLEANFILES' variable. Declarative is always better than
> procedural.
OK for master.
Thanks!
>
>>From bebfa13c933f2f88f78f35abdbced9bebfab6711 Mon Sep 17 00:00:00 2001
> From: Bruno Haible <bruno@clisp.org>
> Date: Fri, 19 Feb 2021 23:54:01 +0100
> Subject: [PATCH] Make it possible to build the tarballs without makeinfo.
>
> * doc/Makefile.am (EXTRA_DIST): Add poke.text.
> (poke.text): Generate in the source directory.
> (MOSTLYCLEANFILES): New variable.
> (clean-local): Remove target.
> ---
> doc/Makefile.am | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/doc/Makefile.am b/doc/Makefile.am
> index 5a39f9f..cdd7f6b 100644
> --- a/doc/Makefile.am
> +++ b/doc/Makefile.am
> @@ -59,12 +59,17 @@ html-local:
> $(builddir)/poke.html/*.html
>
> # Generation of the plain text manual.
> +# We distribute it in the tarballs, since it requires makeinfo to make.
>
> pkgdata_DATA += poke.text
> +EXTRA_DIST += poke.text
>
> poke.text: $(srcdir)/poke.texi
> - $(MAKEINFO) --plaintext $(srcdir)/poke.texi \
> - > poke.text
> + $(MAKEINFO) --plaintext $(srcdir)/poke.texi > poke.txmp
> + rm -f $(srcdir)/poke.text
> + mv poke.txmp $(srcdir)/poke.text
>
> -clean-local:
> - rm -f pvm-insns.texi nodelist poke.text
> +MOSTLYCLEANFILES = \
> + pvm-insns.texi \
> + nodelist \
> + poke.txmp poke.text