Re: Avoid error message during "make check"

[Jose E. Marchesi]

Hi Bruno.

> On FreeBSD 12/x86_64, building and installing poke 0.91 succeeds.
>
> Preparations:
>   # pkg install boehm-gc readline json-c tk87 libtextstyle dejagnu
>
> Configuration:
>   $ BDW_GC_CFLAGS=""; BDW_GC_LIBS="-lgc"; export BDW_GC_CFLAGS BDW_GC_LIBS
>   $ ./configure CPPFLAGS="-I/usr/local/include -Wall" \
>                 LDFLAGS="-L/usr/local/lib"
>
> When doing 'make check' (with 'make', not 'gmake'), there is an error message:
>
> $ make check
> ...
>               === poke Summary ===
>
> # of expected passes          5164
> # of unsupported tests                3
> /bin/sh: ../inputrc: Permission denied
> *** Error code 126
>
> Stop.
> make[3]: stopped in /usr/home/bruno/poke-0.91/build/testsuite
>
> The reference $(RM) to an undefined make variable expands to empty.
>
> The attached proposed patch fixes it.
>
>>From ddad348f6a083175ec7ec1db45bf8a36c08fde47 Mon Sep 17 00:00:00 2001
> From: Bruno Haible <bruno@clisp.org>
> Date: Wed, 24 Feb 2021 01:28:15 +0100
> Subject: [PATCH] Avoid error message during "make check".
>
> * testsuite/Makefile.am (check-DEJAGNU): Don't use undefined variable RM.
> ---
>  testsuite/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testsuite/Makefile.am b/testsuite/Makefile.am
> index 05d0df0..c20ee95 100644
> --- a/testsuite/Makefile.am
> +++ b/testsuite/Makefile.am
> @@ -37,7 +37,7 @@ if HAVE_DEJAGNU
>               $$runtest --tool $(DEJATOOL) --srcdir $${srcdir} --objdir 
> $(builddir) \
>                          SHELL="$(SHELL)" \
>                       $(RUNTESTFLAGS); \
> -             $(RM) $(top_builddir)/inputrc; \
> +       rm -f $(top_builddir)/inputrc; \
>       else \
>         >&2 echo "ERROR: could not find \`runtest'"; \
>         exit 1; :;\

I always thought make variables like $(RM) came from configure, and not
from make itself.

OK for master.
Thanks!