Re: [PATCH v2 1/2] Distribute vim syntax highlighting

[Thomas Weißschuh]

Hi Jose,

On Mo, 2021-03-15T00:13+0100, Jose E. Marchesi wrote:
> > +dnl editor syntax definitions
> > +AC_ARG_WITH([vimdir],
> > + [AS_HELP_STRING([--with-vimdir],
> > +                 [override the default vim directory])],
> > + [ vimdir="$withval"
> > +   AC_MSG_CHECKING([where vim files should go])
> > +   AC_MSG_RESULT([$vimdir])],
> > + [ vimdir='${datadir}/vim/vimfiles' ]
> > +)
> > +AC_SUBST([vimdir])
> 
> I wonder how robust is this, to AC_SUBST `vimdir' instead of a VIMDIR
> and then definining vimdir as a regular Automake variable in
> etc/Makefile.am...

The current code does create a "vimdir = @vimdir@" line in etc/vim/Makefile.in.
Also it is similar to how the emacs "lispdir" is handled.
See [0] and lispdir.m4.

I'm not that familiar with autotools, so maybe I missed some details.

Thomas

[0] 
https://www.gnu.org/software/automake/manual/html_node/Hard_002dCoded-Install-Paths.html
 (search for "lispdir")