Re: [PATCH 11/12] libpoke: Add `format`

poke-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 11/12] libpoke: Add `format`

From:	Jose E. Marchesi
Subject:	Re: [PATCH 11/12] libpoke: Add `format`
Date:	Thu, 27 May 2021 20:29:40 +0200
User-agent:	Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi Mohammad.

Before reviewing this patch in detail I have got a general question for
you.

Have you considered to use a single AST node type for both PRINT and
FORMAT?  In that case, what led you to not use that approach?

The same applies to the corresponding anal, trans, etc handlers.

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 07/12] libpoke: Add `__pkl_unsafe_string_set` builtin, (continued)
- [PATCH 08/12] libpoke: Fix printf %v for strings to give valid literals, Mohammad-Reza Nabipoor, 2021/05/25
  - Re: [PATCH 08/12] libpoke: Fix printf %v for strings to give valid literals, Jose E. Marchesi, 2021/05/27
    - Re: [PATCH 08/12] libpoke: Fix printf %v for strings to give valid literals, Mohammad-Reza Nabipoor, 2021/05/29
- [PATCH 09/12] libpoke: Fix a bug and add assertions to pvm_make_*, Mohammad-Reza Nabipoor, 2021/05/25
  - Re: [PATCH 09/12] libpoke: Fix a bug and add assertions to pvm_make_*, Jose E. Marchesi, 2021/05/27
    - Re: [PATCH 09/12] libpoke: Fix a bug and add assertions to pvm_make_*, Mohammad-Reza Nabipoor, 2021/05/29
- [PATCH 10/12] libpoke: Add skeleton for string properties instructions, Mohammad-Reza Nabipoor, 2021/05/25
- [PATCH 11/12] libpoke: Add `format`, Mohammad-Reza Nabipoor, 2021/05/25
  - Re: [PATCH 11/12] libpoke: Add `format`, Jose E. Marchesi <=
    - Re: [PATCH 11/12] libpoke: Add `format`, Mohammad-Reza Nabipoor, 2021/05/27
    - Re: [PATCH 11/12] libpoke: Add `format`, Jose E. Marchesi, 2021/05/27
    - Re: [PATCH 11/12] libpoke: Add `format`, Mohammad-Reza Nabipoor, 2021/05/27
  - Re: [PATCH 11/12] libpoke: Add `format`, Jose E. Marchesi, 2021/05/29
- [PATCH 12/12] pvm.jitter: Wrap std string functions, Mohammad-Reza Nabipoor, 2021/05/25
  - Re: [PATCH 12/12] pvm.jitter: Wrap std string functions, Jose E. Marchesi, 2021/05/27
    - Re: [PATCH 12/12] pvm.jitter: Wrap std string functions, Mohammad-Reza Nabipoor, 2021/05/29
- Re: [PATCH 00/12] Add format function, Jose E. Marchesi, 2021/05/27

Prev by Date: Re: [PATCH 08/12] libpoke: Fix printf %v for strings to give valid literals
Next by Date: Re: [PATCH 11/12] libpoke: Add `format`
Previous by thread: [PATCH 11/12] libpoke: Add `format`
Next by thread: Re: [PATCH 11/12] libpoke: Add `format`
Index(es):
- Date
- Thread