Re: [PATCH] ios: call `fflush' on output streams

[Jose E. Marchesi]

Hi Mohammad.
Thanks for the patch.

> diff --git a/libpoke/ios-dev-stream.c b/libpoke/ios-dev-stream.c
> index 952af51e..873833be 100644
> --- a/libpoke/ios-dev-stream.c
> +++ b/libpoke/ios-dev-stream.c
> @@ -249,12 +249,14 @@ static int
>  ios_dev_stream_flush (void *iod, ios_dev_off offset)
>  {
>    struct ios_dev_stream *sio = iod;
> +
> +  if (sio->flags & IOS_F_WRITE)
> +    fflush (sio->file);
>    if (sio->flags & IOS_F_READ
>        && offset > ios_buffer_get_begin_offset (sio->buffer)
>        && offset <= ios_buffer_get_end_offset (sio->buffer))
>      return ios_buffer_forget_till (sio->buffer, offset);
> -  else
> -    return IOS_OK;
> +  return IOS_OK;
>  }

I think a stream IOS must have either IOS_F_WRITE or IOS_F_READ set, but
not both, right?

In that case, wouldn't the code be more clear if you put the fflush in
the `else' part?  You could also put an `assert (sio->flags &
IOS_F_WRITE)' there.

WDYT?