Re: [PATCH] poke: disable termios and sigaction code on Windows

[Arsen Arsenović]

Hi,

Hannes Domani via poke-devel <poke-devel@gnu.org> writes:

>  Am Mittwoch, 15. Februar 2023, 22:04:59 MEZ hat Jose E. Marchesi 
> <jemarch@gnu.org> Folgendes geschrieben:
>
>> Hi Hannes.
>>
>> Thanks for the patch.
>>
>> I am wondering, if these facilities are commented out, what happens in
>> Windows when:
>>
>> 1) You are in the (poke) prompt and you press Ctrl-C
>
> Here nothing happens at all, which seems fine to me.

This is actually subtly wrong.  That should reset the prompt (and do the
rest of the stuff demanded by that signal handler).

>
>> 2) You execute `while (1);' from the prompt, then you press Ctrl-C
>
> The execution stops, apparently because of the pvm_handle_signal signal
> handler, set by pvm_run.

If that code can set signal handlers, why can't this code?

I suspect that we don't want to use conditional compilation like this
anyway, since it raises portability concerns into code that really
shouldn't show it.  Disabling parts of functionality to appease that is
likely a bad idea, increasing both complexity and the surprise factor.

Maybe there's some Gnulib module that can handle this for us?  If not,
we should probably invent some solution in coordination with it rather
than doing this.

Have a lovely day.
-- 
Arsen Arsenović

signature.asc
Description: PGP signature