Re: [platform-testers] GNU poke 3.90.0 pre-released in alpha.gnu.org

[Bruno Haible]

Jose E. Marchesi wrote:
> Please report any problem found with the pre-release, comments or
> patches to poke-devel@gnu.org.

There is a major problem with the test suite:

On Ubuntu 22.04/x86_64 "make check" fails:
================================================================================
Making a new site.exp file ...
Using ../../testsuite/lib/poke.exp as tool init file.
Test run by bruno on Sun Jan 21 19:19:14 2024
Native configuration is x86_64-pc-linux-gnu

                === poke tests ===

Schedule of variations:
    unix

Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for 
target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using /build/poke-3.90.0/testsuite/config/unix.exp as tool-and-target-specific 
interface file.
Running /build/poke-3.90.0/testsuite/poke.cmd/cmd.exp ...
Running /build/poke-3.90.0/testsuite/poke.libpoke/libpoke.exp ...
Running /build/poke-3.90.0/testsuite/poke.map/map.exp ...
Running /build/poke-3.90.0/testsuite/poke.pickles/pickles.exp ...
Running /build/poke-3.90.0/testsuite/poke.pkl/pkl.exp ...
Running /build/poke-3.90.0/testsuite/poke.pktest/pktest.exp ...
Running /build/poke-3.90.0/testsuite/poke.pokefmt/pokefmt.exp ...
ERROR: tcl error sourcing /build/poke-3.90.0/testsuite/poke.pokefmt/pokefmt.exp.
ERROR: pokefmt: pk_load() failed for pokefmt.pk
    while executing
"exec $POKEFMT < $fin > $fout"
    (procedure "pokefmt_run" line 12)
    invoked from within
"pokefmt_run 1 "Hi" "Hi""
    (file "/build/poke-3.90.0/testsuite/poke.pokefmt/pokefmt.exp" line 62)
    invoked from within
"source /build/poke-3.90.0/testsuite/poke.pokefmt/pokefmt.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source /build/poke-3.90.0/testsuite/poke.pokefmt/pokefmt.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name""
Running /build/poke-3.90.0/testsuite/poke.repl/repl.exp ...
Running /build/poke-3.90.0/testsuite/poke.std/std.exp ...
Running /build/poke-3.90.0/testsuite/poke.time/time.exp ...

                === poke Summary ===

# of expected passes            7894
# of expected failures          3
# of unsupported tests          3
make[4]: *** [Makefile:5897: check-DEJAGNU] Error 2
make[4]: Leaving directory '/build/poke-3.90.0/build-64/testsuite'
make[3]: *** [Makefile:5775: check-am] Error 2
make[3]: Leaving directory '/build/poke-3.90.0/build-64/testsuite'
make[2]: *** [Makefile:5594: check-recursive] Error 1
make[2]: Leaving directory '/build/poke-3.90.0/build-64/testsuite'
make[1]: *** [Makefile:2861: check-recursive] Error 1
make[1]: Leaving directory '/build/poke-3.90.0/build-64'
make: *** [Makefile:3162: check] Error 2
================================================================================

I've added logging of POKEFMT, fin, fout, and when I execute this command
standalone, I indeed get the same error:

$ ./../pokefmt/pokefmt < /tmp/pokefmt-data.379245/input > 
/tmp/pokefmt-data.379245/output 
pokefmt: pk_load() failed for pokefmt.pk

Here, /tmp/pokefmt-data.379245/input is a regular file of length 2
with contents "Hi", and /tmp/pokefmt-data.379245/output is a regular file
of length 0.

There is a file $(top_srcdir)/pokefmt/pokefmt.pk.

The testsuite/Makefile set
  POKEPICKLESDIR="$(top_srcdir)/pickles"
  POKE_LOAD_PATH="$(top_srcdir)/poke"
for the duration of the 'runtest' invocation. None of these directories
contains a pokefmt.pk file.

- Should POKEPICKLESDIR be modified to include $(top_srcdir)/pokefmt ?
- Should POKE_LOAD_PATH be modified to include $(top_srcdir)/pokefmt ?
- Should the pokefmt program set its own modified environment variables?

Bruno