Re: [PATCH] poke: Change addresses in commands to unsigned

[Mohammad-Reza Nabipoor]

Hi Andreas,

On Fri, Jan 26, 2024 at 09:06:45AM +0100, Andreas Klinger wrote:
> 2024-01-25  Andreas Klinger  <ak@it-klinger.de>
> 
>         * poke/pk-cmd.h: New command arg type PK_CMD_ARG_UINT
>         * poke/pk-cmd.c (pk_atou): New function
>         * poke/pk-cmd-ios.c (pk_cmd_mmap, pk_cmd_sub):
>                                    Change base and size to PK_CMD_ARG_UINT
> ---
> 
> This patch is also available in the poke repo as branch
> "anderl/unsigned-address-command".
> 
> Background:
> Addresses are interpreted as integer so far. For example on a 32 bit system it
> can happen that one is using the address 0x80000000 or a higher one which is
> interpreted as negative value and thus a segmentation fault happens when 
> trying
> to use it.
> 
>  poke/pk-cmd-ios.c | 20 ++++++++++----------
>  poke/pk-cmd.c     | 32 ++++++++++++++++++++++++++++++++
>  poke/pk-cmd.h     |  3 +++
>  3 files changed, 45 insertions(+), 10 deletions(-)
> 

Thanks for the patch.

I know it's late, but you forgot to add an entry to ChangeLog!
We write a new entry in ChangeLog and then copy it to the commit message.


Regards,
Mohammad-Reza