Re: [bugs #12035] AGGREGATE gets its sums wrong!

[John Darrington]

Hi Ben,

On closer inspection, this bug is not a problem with AGGREGATE, but
with the DATA LIST.



So far as I can tell, the offending code is: 

RCS file: /cvsroot/pspp/pspp/src/data-in.c,v
retrieving revision 1.12
diff -b -w -r1.12 data-in.c
218,219d217
<   else if (!got_dot)
<     exponent -= i->format.d;

I can't see any good reason for these lines.  When I remove them, the
problem goes away, and it passes all tests except:

550c550
< number("123", f3.1) => 12.30
---
> number("123", f3.1) => 123.00
compare optimizing output
FAILED
FAIL: xforms/expressions.sh

But if I understand what it's doing, then the test is wrong anyway.


Can you have a look at it.

Thanks.


-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://wwwkeys.pgp.net or any PGP keyserver for public key.

pgpsc_ikeVG3n.pgp
Description: PGP signature