Re: Long variable names

[Jason Stover]

> * test/expressions/randist.sh bails out on the beta and F distribution
>   tests, but as per previous discussions, I think this is a problem
>   with the test rather than the code.  I'll leave it to the numerical
>   analysts to work out what's going on.

I could not reproduce this problem with a recent checkout. I used a
slightly modified version of randist.sh, as well as the usual
randist.sh.  The modified randist.sh is pasted below. Running diff -b
-B by hand returned no difference between the files written by
randist.sh and the files in tests/expressions/randist/.

-Jason

----------modified randist.sh------------------------------------
#! /bin/sh

# Tests random distribution functions.

TEMPDIR=/tmp/pspp-tst

# ensure that top_srcdir is absolute
top_srcdir=$HOME/src/pspp
cd $top_srcdir;

export STAT_CONFIG_PATH=$top_srcdir/config


cleanup()
{
     if [ x"$PSPP_TEST_NO_CLEANUP" != x ] ; then 
        echo NOT removing directory $TEMPDIR
        return ; 
     fi
     rm -rf $TEMPDIR
}


fail()
{
    echo $activity
    echo FAILED
#    cleanup;
    exit 1;
}


no_result()
{
    echo $activity
    echo NO RESULT;
    cleanup;
    exit 2;
}

pass()
{
#    cleanup;
    exit 0;
}

mkdir -p $TEMPDIR
cd $TEMPDIR

activity="run script to generate random distribution test command file"
perl $top_srcdir/tests/expressions/randist/randist.pl \
    < $top_srcdir/tests/expressions/randist/randist.txt \
    > randist.pspp
if [ $? -ne 0 ] ; then no_result ; fi

activity="run command file"
$HOME/src/pspp/src/pspp --testing-mode -o raw-ascii \
    $TEMPDIR/randist.pspp >$TEMPDIR/randist.err 2> $TEMPDIR/randist.out
if [ $? -ne 0 ] ; then fail ; fi

for d in beta cauchy chisq exp f gamma laplace logistic lnormal \
         normal pareto t uniform weibull; do
    activity="compare output for $d distribution"
    diff -B -b $top_srcdir/tests/expressions/randist/$d.out $TEMPDIR/$d.out
    if [ $? -ne 0 ] ; then fail ; fi
done

pass
----------------randist.sh----------------------

> 
> * Currently, the long variable names are not actually displayed in the
>   output.  This should be easy to implement, but will break nearly all
>   the tests, since variable names are now case sensitive for display
>   purposes (but they're case insensitive in comparisons), and many of
>   the tests are sloppy when it comes to case consistency.
> 
> 
> J'
> 
> 
> -- 
> PGP Public key ID: 1024D/2DE827B3 
> fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
> See http://pgp.mit.edu or any PGP keyserver for public key.
> 
> 



> _______________________________________________
> pspp-dev mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/pspp-dev


-- 
address@hidden
SDF Public Access UNIX System - http://sdf.lonestar.org