Re: variable structure modification

[John Darrington]

On Tue, Nov 22, 2005 at 03:47:26PM +0000, Jason Stover wrote:
         /* Values of a categorical variable which are in the active
            file. Procedures need vectors with binary entries, so any
            variable of type ALPHA will have its values stored here. */
         struct cat_vals *obs_vals;
         bool values_stored; /* True if a variables' values are encoded in
                                obs_vals.  A procedure may create
                                obs_vals, then another procedure may
                                destroy it. If values_stored is true, the
                                procedure that needs the encoding does not
                                need to pass the data again to find the
                                encoding. If values_stored is false, the
                                procedure must make an extra data pass.
                             */

Isn't values_stored redundant? Ie, if values_stored==false, then
obs_vals==0.  I'd suggest just dropping the bool and testing
the obs_vals to see if there is an encoding to be found.

But it sounds like a generally a good idea, and will probably allow me
to revisit the T-TEST and ONEWAY commands and possibly get rid of the
nasty group_vars and factor_stats modules (which basically do the same
as each other).
     
J'

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

signature.asc
Description: Digital signature