[patch #5567] formatted data input update and regression suite

[John Darrington]

Update of patch #5567 (project pspp):

             Assigned to:                     jmd => blp                    

    _______________________________________________________

Follow-up Comment #1:

Only a few points:

0 There are a number of places where you have +char tmp[6];+ and later you
are indexing into tmp with some integer expression.  I wonder if it would be
safer to use +struct string+ in these places instead?

0 There are a number of instances of isxdigit, and other instances of
isdigit/isspace/isalpha.  Are you sure that locale/non-locale dependent
versions are being used where appropriate?

0 I still think that it may be a good idea (at least eventually) to  allow
locale dependent versions of data input.  For example, users in a German
locale might well have a large text file of the form:
+verbatim+
Di Okt 21 18:49:56 CST 2006
Mi Okt 22 17:59:36 CST 2006
-verbatim-
_etc_
which they'd want to parse into dates in PSPP.



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?5567>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/