[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[patch #5907] Implement ADD DOCUMENT command.
From: |
Ben Pfaff |
Subject: |
[patch #5907] Implement ADD DOCUMENT command. |
Date: |
Wed, 02 May 2007 14:38:23 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061205 Iceweasel/2.0.0.1 (Debian-2.0.0.1+dfsg-1) |
Update of patch #5907 (project pspp):
Status: Ready For Test/Review => Works For Me
_______________________________________________________
Follow-up Comment #1:
Some quibbles:
In the documentation, I don't think that the . should be on a separate line;
although that's valid syntax, it's not a style I've commonly seen.
In cmd_add_documents, please add a period to the end of the error message.
I don't think the "x / 80" => "DIV_RND_UP (x, 80)" changes are correct. In
each case, if the number of bytes is not a multiple of 80, then rounding up
will cause subsequent code to read beyond the end of the document string.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?5907>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/