[patch #6359] Eliminate var_get_value_name

[Ben Pfaff]

Update of patch #6359 (project pspp):

                  Status:   Ready For Test/Review => Works For Me           

    _______________________________________________________

Follow-up Comment #1:

Looks good.

Could you update the documentation on var_get_value_name in
doc/dev/concepts.texi?

var_append_value_name could use ds_put_uninit instead of writing to a
temporary buffer followed by ds_put_cstr.

It is a little sad that we have to add init and destroy calls for all of the
users of the new function, but I don't see a way to avoid it.  Some of the
uses can save one line of by using DS_EMPTY_INITIALIZER as an initializer
instead of calling ds_init_empty, but it's not a big deal either way.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6359>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/