pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #6358] Text import patch pre-review take 2


From: Ben Pfaff
Subject: [patch #6358] Text import patch pre-review take 2
Date: Sat, 26 Jan 2008 22:57:45 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061205 Iceweasel/2.0.0.1 (Debian-2.0.0.1+dfsg-1)

Follow-up Comment #5, patch #6358 (project pspp):

>The changes you made to glade-register.c are incorrect.

Yes, that represents a failed experiment.  The goal was to teach glade how to
construct a GtkAssistant, which it doesn't know how to do.  Those changes will
get dropped entirely.

>Nothing appears to use psppliststore.c (for which I'm grateful). 

Heh.  Yes, that will be dropped too.

>Some of the copyright notices have the year 2007. This should be 
>changed to 2008. 

Thanks, will do.

>The variable sheet has it's row numbers starting from zero. For 
>consistancy, perhaps they should start from unity. 

OK, will do.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6358>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]