[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[patch #6492] More robust detection of libncurses
From: |
Ben Pfaff |
Subject: |
[patch #6492] More robust detection of libncurses |
Date: |
Fri, 18 Apr 2008 03:09:09 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061205 Iceweasel/2.0.0.1 (Debian-2.0.0.1+dfsg-1) |
Update of patch #6492 (project pspp):
Status: Ready For Test/Review => Works For Me
_______________________________________________________
Follow-up Comment #1:
Thanks for taking care of this. It looks good, except for the following
minor points.
In configure.ac:
>AC_CHECK_PROGS([NCURSES_CONFIG], [ncurses{1..9}-config])
Please don't use brace expansion. It is a bash extension not part of the
POSIX shell specification. Since we only know about ncurses5-config and
ncurses8-config, I would just write those explicitly.
Also, it is merely nitpicking, but I don't see a good reason to rename
HAVE_NCURSES to LIBNCURSES_USABLE.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?6492>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/