[patch #6626] Append numeric casetranslator

[Ben Pfaff]

Follow-up Comment #1, patch #6626 (project pspp):

I think that the patch is reversed; that is, the + lines are what is in the
source tree now and the - lines are being added.

Please don't put two statements on one line like this:
-      if (n_missing) *n_missing = 0;

I don't know why "double_func" has that name.

The comment on casereader_create_append_numeric could state what the value of
'n' passed to the function is.  I think it's 0 for the first case, 1 for the
second, and so on.

Looks good otherwise.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6626>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/