Re: Suggestions

[Rémi Dewitte]

Hello,

Working with pspp-0.6.1 I am glad it works fine. Nevertheless I encountered two minor issues for which I have patched a bit pspp.

First one is the ability to import CSV file with DOS endlines. I don't know whether it is the right place to trim the '\r'.

Second one is the ability to have long value labels. Is it an old limitation which could be removed ?

What do you think ?

diff -r -c pspp-0.6.1/src/data/data-in.c pspp-0.6.1.patched/src/data/
data-in.c                                                                                                              
*** pspp-0.6.1/src/data/data-in.c       2008-06-09 06:37:38.000000000 +0200                                                                                                                 
--- pspp-0.6.1.patched/src/data/data-in.c       2009-01-28 12:00:00.000000000 +0100                                                                                                         
***************                                                                                                                                                                             
*** 1232,1238 ****                                                                                                                                                                          
  static bool                                                                                                                                                                               
  trim_spaces_and_check_missing (struct data_in *i)                                                                                                                                         
  {                                                                                                                                                                                         
!   ss_trim (&i->input, ss_cstr (" "));                                                                                                                                                     
    if (ss_is_empty (i->input) || ss_equals (i->input, ss_cstr (".")))                                                                                                                      
      {                                                                                                                                                                                     
        default_result (i);                                                                                                                                                                 
--- 1232,1238 ----                                                                                                                                                                          
  static bool                                                                                                                                                                               
  trim_spaces_and_check_missing (struct data_in *i)                                                                                                                                         
  {                                                                                                                                                                                         
!   ss_trim (&i->input, ss_cstr (" \r"));                                                                                                                                                   
    if (ss_is_empty (i->input) || ss_equals (i->input, ss_cstr (".")))                                                                                                                      
      {                                                                                                                                                                                     
        default_result (i);                                                                                                                                                                                                                                                                                          
diff -r -c pspp-0.6.1/src/language/dictionary/value-labels.c pspp-0.6.1.patched/src/language/dictionary/value-labels.c                                                                      
*** pspp-0.6.1/src/language/dictionary/value-labels.c   2008-06-09 06:37:38.000000000 +0200                                                                                                 
--- pspp-0.6.1.patched/src/language/dictionary/value-labels.c   2009-01-20 12:49:34.000000000 +0100                                                                                         
***************
*** 181,188 ****

        if (ds_length (&label) > 60)
        {
!         msg (SW, _("Truncating value label to 60 characters."));
!         ds_truncate (&label, 60);
        }

        for (i = 0; i < var_cnt; i++)
--- 181,188 ----

        if (ds_length (&label) > 60)
        {
!         msg (SW, _("Truncating value label to 60 characters. (Not doing it will fail ???)"));
!         //ds_truncate (&label, 60);
        }

        for (i = 0; i < var_cnt; i++)

Rémi