[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[patch #6785] Default output precision
From: |
John Darrington |
Subject: |
[patch #6785] Default output precision |
Date: |
Sat, 28 Mar 2009 07:38:53 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.6) Gecko/2009020409 Iceweasel/3.0.6 (Debian-3.0.6-1) |
Follow-up Comment #2, patch #6785 (project pspp):
I'm sending this back for a second review. I've fixed up all Ben's
suggestions except:
const struct variable *wv = dict_get_weight (dict);
const struct fmt_spec *wfmt = wv ? var_get_print_format (wv) : & F_8_0;
Whilst a helper function might be useful, I couldn't identify a suitable file
to put it in which wouldn't have required additional dependencies. I don't
think copying two lines is particularly onerous anyway.
I still need to fix up the tests to take account of the changed formats.
Otherwise I think it's ready to be checked into stable.
(file #17828)
_______________________________________________________
Additional Item Attachment:
File name: output-precision2.patch Size:84 KB
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?6785>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/