Re: problem with odf driver

[John Darrington]

On Wed, Feb 24, 2010 at 10:29:12AM -0800, Ben Pfaff wrote:
     Ben Pfaff <address@hidden> writes:
     
     > John Darrington <address@hidden> writes:
     >
     >> On Tue, Feb 23, 2010 at 10:29:15PM -0800, Ben Pfaff wrote:
     >>
     >>      > I might take a few hours to write code to create a .zip file.
     >>      > It looks like it's pretty trivial as long as you don't bother
     >>      > with actual compression.  I think the hardest part is probably
     >>      > writing the CRC-32 function.
     >>      
     >>      I did this tonight, so there is no need for a "zip" program on
     >>      master any longer.
     >>
     >> This seems to have caused a problem.  
     >> tests/command/get-data-gnm.sh now crashes.
     >>
     >> It seems that the crc32 function provided by gnulib has a different 
signature
     >> to that expected by zlib :(
     >
     > I thought I must be hallucinating, because I couldn't conceive
     > how get-data-gnm.sh and odt.c were related.  Thanks for pointing
     > out the problem.
     
     I pushed a fix.

The fix seems to work for me.  But I wonder if "if test $HAVE_ZLIB = yes; then" 
is sufficient?  There are other libraries which use crc32, notably libpng - our
gui loads a lot of png files.

J'

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

signature.asc
Description: Digital signature