[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [warnings 4/7] ONEWAY: Fix declaration-after-statement warning.
From: |
John Darrington |
Subject: |
Re: [warnings 4/7] ONEWAY: Fix declaration-after-statement warning. |
Date: |
Sat, 18 Sep 2010 06:52:36 +0000 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
This one looks fine.
On Fri, Sep 17, 2010 at 09:36:29PM -0700, Ben Pfaff wrote:
C90 requires declarations to precede statements within a block.
---
src/language/stats/oneway.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/language/stats/oneway.c b/src/language/stats/oneway.c
index ba7fc5b..aa8a255 100644
--- a/src/language/stats/oneway.c
+++ b/src/language/stats/oneway.c
@@ -360,14 +360,14 @@ updateit (void *user_data,
const union value *valx = case_data (c, varp);
+ struct descriptive_data *dd_total = aux2;
+
+ double weight;
+
if ( var_is_value_missing (varp, valx, exclude))
return;
- struct descriptive_data *dd_total = aux2;
-
- double weight = 1.0;
- if (wv)
- weight = case_data (c, wv)->f;
+ weight = wv != NULL ? case_data (c, wv)->f : 1.0;
moments1_add (dd->mom, valx->f, weight);
if (valx->f * weight < dd->minimum)
--
1.7.1
_______________________________________________
pspp-dev mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/pspp-dev
--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.
signature.asc
Description: Digital signature