Re: [q2c 00/12] Fix i18n problems in q2c-generated strings

[Ben Pfaff]

Thank you for taking a look.  I pushed these to master.

John Darrington <address@hidden> writes:

> All these changes look fine to me.
>
> J'
>
> Sat, Nov 05, 2011 at 08:11:22PM -0700, Ben Pfaff wrote:
>      Back in March I posted a patch to fix i18n problems with q2c:
>       http://lists.gnu.org/archive/html/pspp-dev/2011-03/msg00039.html
>      John pointed out that the strategy wasn't so great:
>       http://lists.gnu.org/archive/html/pspp-dev/2011-04/msg00004.html
>      Here (finally) is a new version that solves the same problem in a
>      better way.  I also fixed a problem with the LOOP command that I
>      discovered along the way.
>      
>      Comments welcome.  I'll commit this in a few days if I don't hear
>      anything back.
>      
>      Thanks,
>      
>      Ben.
>      
>      Ben Pfaff (12):
>        SET: Warn for more obsolete subcommands.
>        settings: Update default MXLOOPS and document.
>        settings: Implement MXLOOPS subcommand.
>        LOOP: Correctly implement MXLOOPS and add a test.
>        lexer: New function lex_error_expecting().
>        lexer: Drop lexer parameter from lex_sbc_missing().
>        lexer: Use error helper functions in more situations.
>        lexer: New functions lex_spec_missing(), lex_spec_only_once().
>        lexer: New function lex_force_string_or_id().
>        q2c: Use new subc_list_error() to report too many subcommands.
>        q2c: Remove final untranslated strings from q2c.c.
>        q2c: Remove gettext.h #include from generated code.
>      
>       doc/dev/q2c.texi                           |   17 +---
>       doc/flow-control.texi                      |    1 +
>       doc/utilities.texi                         |    1 +
>       src/data/settings.c                        |    2 +-
>       src/language/control/loop.c                |   10 +--
>       src/language/data-io/combine-files.c       |    2 +-
>       src/language/data-io/file-handle.q         |   11 ++-
>       src/language/data-io/get-data.c            |    7 +-
>       src/language/data-io/get.c                 |    4 +-
>       src/language/data-io/inpt-pgm.c            |    2 +-
>       src/language/data-io/save-translate.c      |   22 ++--
>       src/language/data-io/save.c                |   10 +-
>       src/language/data-io/trim.c                |    2 +-
>       src/language/dictionary/attributes.c       |    2 +-
>       src/language/dictionary/formats.c          |    4 +-
>       src/language/dictionary/modify-variables.c |   19 ++--
>       src/language/dictionary/mrsets.c           |    9 +-
>       src/language/dictionary/numeric.c          |    2 +-
>       src/language/dictionary/rename-variables.c |   21 +---
>       src/language/expressions/parse.c           |    3 +-
>       src/language/lexer/lexer.c                 |  129 
> ++++++++++++++++++++++++--
>       src/language/lexer/lexer.h                 |   10 ++-
>       src/language/lexer/q2c.c                   |  137 
> ++++------------------------
>       src/language/lexer/subcommand-list.c       |   17 +++-
>       src/language/lexer/subcommand-list.h       |    4 +-
>       src/language/stats/aggregate.c             |    2 +-
>       src/language/stats/frequencies.q           |    2 +-
>       src/language/stats/npar.c                  |    4 +-
>       src/language/stats/sort-criteria.c         |    9 +-
>       src/language/stats/t-test-parser.c         |    2 +-
>       src/language/utilities/include.c           |   18 +---
>       src/language/utilities/permissions.c       |    3 +-
>       src/language/utilities/set.q               |   53 ++++++++---
>       tests/language/control/do-repeat.at        |    2 +-
>       tests/language/control/loop.at             |   43 ++++++++-
>       tests/language/data-io/inpt-pgm.at         |    2 +-
>       tests/language/dictionary/mrsets.at        |    4 +-
>       tests/language/lexer/q2c.at                |    4 +-
>       tests/language/stats/t-test.at             |    4 +-
>       39 files changed, 334 insertions(+), 266 deletions(-)
>      
>      -- 
>      1.7.2.5
>      
>      
>      _______________________________________________
>      pspp-dev mailing list
>      address@hidden
>      https://lists.gnu.org/mailman/listinfo/pspp-dev

-- 
Ben Pfaff 
http://benpfaff.org