Re: [PATCH 01/13] psppire-dict: g_return_if_fail for idx in psppire_dict_get_variable().

[Ben Pfaff]

John Darrington <address@hidden> writes:

>      +  g_return_val_if_fail (idx < 0 || dict_get_var_cnt (d->dict) <= idx, 
> NULL);
>
> Personally I prefer assertions to be written in their separate components 
> rather than ored 
> together, like this:
>
>  g_return_val_if_fail (idx < 0, NULL);
>  g_return_val_if_fail (dict_get_var_cnt (d->dict) <= idx, NULL);
>    
> That way, when the condition fails, it's easier to find out which part of the 
> condition is failing.

Fair enough.  I made that change and pushed this commit.

I'll leave the rest until you have time to look them over.

Thanks,

Ben.