Re: [PATCH 0/4] third set of psppsheet changes

[John Darrington]

All these look fine to me.

On Fri, Apr 20, 2012 at 10:11:51PM -0700, Ben Pfaff wrote:
     This is the third set of psppsheet changes.  These are the last
     few changes before a long series that introduces PsppSheetView
     as a clone of GtkTreeView and then refactors it into a more
     useful widget for displaying a spreadsheet.
     
     Feedback welcomed.  I'll give this a few days or until I hear back
     on reviews.
     
     Thanks,
     
     Ben.
     
     Ben Pfaff (4):
       gui: New type PsppireEmptyListStore.
       gui: New boxed type for struct fmt_spec.
       gui: New widget PsppireValueEntry for editing a "union value".
       helper: Move escape_underscores() here.
     
      src/ui/gui/automake.mk                |    6 +
      src/ui/gui/helper.c                   |   20 ++
      src/ui/gui/helper.h                   |    1 +
      src/ui/gui/psppire-empty-list-store.c |  369 ++++++++++++++++++++++++++
      src/ui/gui/psppire-empty-list-store.h |   68 +++++
      src/ui/gui/psppire-format.c           |   46 ++++
      src/ui/gui/psppire-format.h           |   28 ++
      src/ui/gui/psppire-value-entry.c      |  455 
+++++++++++++++++++++++++++++++++
      src/ui/gui/psppire-value-entry.h      |  104 ++++++++
      src/ui/gui/text-data-import-dialog.c  |  367 ++++-----------------------
      10 files changed, 1149 insertions(+), 315 deletions(-)
      create mode 100644 src/ui/gui/psppire-empty-list-store.c
      create mode 100644 src/ui/gui/psppire-empty-list-store.h
      create mode 100644 src/ui/gui/psppire-format.c
      create mode 100644 src/ui/gui/psppire-format.h
      create mode 100644 src/ui/gui/psppire-value-entry.c
      create mode 100644 src/ui/gui/psppire-value-entry.h
     
     -- 
     1.7.2.5
     
     
     _______________________________________________
     pspp-dev mailing list
     address@hidden
     https://lists.gnu.org/mailman/listinfo/pspp-dev

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.

signature.asc
Description: Digital signature