Re: Another bug in psppsheet branch

[Ben Pfaff]

John Darrington <address@hidden> writes:

> I noticed the following problem using the psppsheet branch as of
> d4ae90b2fe74d2d1427afad35d32c9e5584211ed
>
> 1. Prepare a .sav file (call it x.sav) with some data.
>
> 2. Start psppire
>
> 3. File | Open and load x.sav (dataset1)
>
> 4. File | New | Data (a new data window will appear: dataset2)
>
> 5. Using the window manager close the window for dataset1
>
> 6. In dataset2:  File | Open and load x.sav
>
>  A lot of Gtk-Criticals appear and the program quickly crashes.

I see the same problem if in step 6 I load y.sav (a different
file), so it doesn't seem related to loading x.sav again.

Here is the first message that valgrind reports on step 6:

Invalid write of size 4
   at 0x4E61EA9: dict_set_callbacks (dictionary.c:153)
   by 0x80A6E4C: psppire_dict_new_from_dict (psppire-dict.c:327)
   by 0x809D598: psppire_data_window_set_property (psppire-data-window.c:874)
   by 0x75F99E5: g_object_constructor (gobject.c:973)
   by 0x75FAB2B: g_object_newv (gobject.c:1261)
   by 0x75FB7EB: g_object_new_valist (gobject.c:1377)
   by 0x75FB906: g_object_new (gobject.c:1095)
   by 0x809CB96: psppire_data_window_new (psppire-data-window.c:1206)
   by 0x808ECB6: new_pdw_cb (executor.c:44)
   by 0x4E72ED4: session_for_each_dataset (session.c:153)
   by 0x808EAC4: execute_syntax (executor.c:160)
   by 0x809ECBC: load_file (psppire-data-window.c:359)
   by 0x80B529B: psppire_window_load (psppire-window.c:676)
   by 0x809CD22: open_data_window (psppire-data-window.c:1299)
   by 0x809E3CD: on_recent_data_select (psppire-data-window.c:705)
   by 0x7601CAB: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
   by 0x75F4139: g_closure_invoke (gclosure.c:767)
   by 0x760A61C: signal_emit_unlocked_R (gsignal.c:3248)
   by 0x760BBFB: g_signal_emit_valist (gsignal.c:2981)
   by 0x760C075: g_signal_emit (gsignal.c:3038)
   by 0x711B423: gtk_menu_shell_activate_item (gtkmenushell.c:1260)
   by 0x711CECE: gtk_menu_shell_button_release (gtkmenushell.c:683)
   by 0x71126C3: gtk_menu_button_release (gtkmenu.c:3005)
   by 0x710BE73: _gtk_marshal_BOOLEAN__BOXED (gtkmarshalers.c:84)
   by 0x75F27A8: g_type_class_meta_marshal (gclosure.c:878)
   by 0x75F4139: g_closure_invoke (gclosure.c:767)
   by 0x760A265: signal_emit_unlocked_R (gsignal.c:3286)
   by 0x760BA7A: g_signal_emit_valist (gsignal.c:2991)
   by 0x760C075: g_signal_emit (gsignal.c:3038)
   by 0x7238155: gtk_widget_event_internal (gtkwidget.c:4943)
   by 0x71044CC: gtk_propagate_event (gtkmain.c:2442)
   by 0x7105856: gtk_main_do_event (gtkmain.c:1647)
   by 0x5093DD9: gdk_event_dispatch (gdkevents-x11.c:2372)
   by 0x7DF4304: g_main_context_dispatch (gmain.c:1960)
   by 0x7DF7FE7: g_main_context_iterate (gmain.c:2591)
   by 0x7DF8526: g_main_loop_run (gmain.c:2799)
   by 0x7105E18: gtk_main (gtkmain.c:1219)
   by 0x809273C: run_inner_loop (main.c:233)
   by 0x7105F80: gtk_main (gtkmain.c:2339)
   by 0x8092672: main (main.c:333)
 Address 0x13a43524 is 108 bytes inside a block of size 124 free'd
   at 0x49DFB6A: free (vg_replace_malloc.c:366)
   by 0x4E64B0D: dict_destroy (dictionary.c:312)
   by 0x80A7465: psppire_dict_finalize (psppire-dict.c:234)
   by 0x75F62D3: g_object_unref (gobject.c:2484)
   by 0x80B1DBC: psppire_var_sheet_set_dictionary (psppire-var-sheet.c:1332)
   by 0x80B2259: psppire_var_sheet_destroy (psppire-var-sheet.c:917)
   by 0x7601CAB: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
   by 0x75F27A8: g_type_class_meta_marshal (gclosure.c:878)
   by 0x75F4067: g_closure_invoke (gclosure.c:767)
   by 0x760A49B: signal_emit_unlocked_R (gsignal.c:3364)
   by 0x760BBFB: g_signal_emit_valist (gsignal.c:2981)
   by 0x760C075: g_signal_emit (gsignal.c:3038)
   by 0x7133180: gtk_object_dispose (gtkobject.c:421)
   by 0x723FED3: gtk_widget_dispose (gtkwidget.c:8691)
   by 0x75F679E: g_object_run_dispose (gobject.c:820)
   by 0x7132E8D: gtk_object_destroy (gtkobject.c:406)
   by 0x704294C: gtk_bin_forall (gtkbin.c:128)
   by 0x7171D3C: gtk_scrolled_window_forall (gtkscrolledwindow.c:1086)
   by 0x707B063: gtk_container_foreach (gtkcontainer.c:1527)
   by 0x707B8F7: gtk_container_destroy (gtkcontainer.c:1066)
   by 0x7173A6B: gtk_scrolled_window_destroy (gtkscrolledwindow.c:875)
   by 0x7601CAB: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
   by 0x75F27A8: g_type_class_meta_marshal (gclosure.c:878)
   by 0x75F4067: g_closure_invoke (gclosure.c:767)
   by 0x760A49B: signal_emit_unlocked_R (gsignal.c:3364)
   by 0x760BBFB: g_signal_emit_valist (gsignal.c:2981)
   by 0x760C075: g_signal_emit (gsignal.c:3038)
   by 0x7133180: gtk_object_dispose (gtkobject.c:421)
   by 0x723FED3: gtk_widget_dispose (gtkwidget.c:8691)
   by 0x75F679E: g_object_run_dispose (gobject.c:820)
   by 0x7132E8D: gtk_object_destroy (gtkobject.c:406)
   by 0x712910B: gtk_notebook_forall (gtknotebook.c:4264)
   by 0x707B063: gtk_container_foreach (gtkcontainer.c:1527)
   by 0x707B8F7: gtk_container_destroy (gtkcontainer.c:1066)
   by 0x712F296: gtk_notebook_destroy (gtknotebook.c:1503)
   by 0x7601CAB: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
   by 0x75F27A8: g_type_class_meta_marshal (gclosure.c:878)
   by 0x75F4067: g_closure_invoke (gclosure.c:767)
   by 0x760A49B: signal_emit_unlocked_R (gsignal.c:3364)
   by 0x760BBFB: g_signal_emit_valist (gsignal.c:2981)
   by 0x760C075: g_signal_emit (gsignal.c:3038)
   by 0x7133180: gtk_object_dispose (gtkobject.c:421)
   by 0x723FED3: gtk_widget_dispose (gtkwidget.c:8691)
   by 0x75F679E: g_object_run_dispose (gobject.c:820)
   by 0x7132E8D: gtk_object_destroy (gtkobject.c:406)
   by 0x7046AE4: gtk_box_forall (gtkbox.c:1251)
   by 0x707B063: gtk_container_foreach (gtkcontainer.c:1527)
   by 0x707B8F7: gtk_container_destroy (gtkcontainer.c:1066)
   by 0x7601CAB: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
   by 0x75F27A8: g_type_class_meta_marshal (gclosure.c:878)