Re: Icons disappeared

[John Darrington]

That doesn't suprise me.

Clearly we are not using the GtkIconSet API properly.  The problem seems only
to manifest itself on Windows but could also happen on other systems if not 
using the default themes.

I'm reading the documentation for Gtk and will try to fix the problem within
a week or so.

J'

On Fri, Sep 06, 2013 at 04:29:05PM +0200, Harry Thijssen wrote:
     Hi
     
     I upgrade the complete installation and the toolset to the latest before
     building PSPP for MSWindows, without the patch to change large to small,
     and there are still no icons available in the toolbar.
     
     Conclusion: upgrading to the latest versions is not the final solution
     (yet).
     
     
     Have fun
     
     
     2013/9/5 John Darrington <address@hidden>
     
     > This is useful information.  Clearly I have not properly understood how
     > GtkIconFactories
     > are supposed to work.  I will read the documentation again and provide a
     > patch to fix this
     > properly.
     >
     > J'
     >
     > On Thu, Sep 05, 2013 at 02:34:24PM +0200, Harry Thijssen wrote:
     >      Bingo:
     >
     >      > In src/ui/gui/psppire.c try changing the string
     >      GTK_ICON_SIZE_LARGE_TOOLBAR to
     >      > GTK_ICON_SIZE_SMALL_TOOLBAR and see what happens (if anything).
     >
     >      This made the icons appear again. And it doesn't look so bad.
     >      I am currently generating a new release candidate it will be
     > available in
     >      less then an hour
     >
     >      This patch seems to work but it is not a clean solution, I can try
     >      upgrading my toolset, but it is less then 2 months old. I don't
     > expect much
     >      form an update.
     >      What else can be done?
     >
     >      Have fun
     >
     >
     >
     > --
     > PGP Public key ID: 1024D/2DE827B3
     > fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
     > See http://keys.gnupg.net or any PGP keyserver for public key.
     >
     >

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.

signature.asc
Description: Digital signature