[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] New module to perform decimal floating point arithmetic for
|
From: |
John Darrington |
|
Subject: |
Re: [PATCH] New module to perform decimal floating point arithmetic for charts. |
|
Date: |
Wed, 14 Jan 2015 10:20:06 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Jan 13, 2015 at 09:24:37PM -0800, Ben Pfaff wrote:
Can you say a few words about the assumptions? At first glance, some of
the functions seem to suffer from catastrophic loss of precision upon
integer overflow, e.g. doesn't that happen in decimal_multiply() if the
intermediate result is greater than ORD_MAX? (Is some kind of care
taken to make sure that this cannot happen?)
Oh you are right. Actually decimal_multiply is unused, so I have removed it.
But the same issue was in decimal_int_multiply. I have fixed this and
added a test for it.
Patch attached.
J'
--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.
0001-Remove-decimal_multiply.patch
Description: Text Data
signature.asc
Description: Digital signature