[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH v13 3/8] hw/ptimer: Update .delta on period/freq chang
From: |
Dmitry Osipenko |
Subject: |
[Qemu-arm] [PATCH v13 3/8] hw/ptimer: Update .delta on period/freq change |
Date: |
Fri, 27 May 2016 20:03:31 +0300 |
Delta value must be updated on period/freq change, otherwise running timer
would be restarted (counter reloaded with old delta). Only m68k/mcf520x
and arm/arm_timer devices are currently doing freq change correctly, i.e.
stopping the timer. Perform delta update to fix affected devices and
eliminate potential further mistakes.
Signed-off-by: Dmitry Osipenko <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
---
hw/core/ptimer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/core/ptimer.c b/hw/core/ptimer.c
index 7e6fc2d..76ebe9b 100644
--- a/hw/core/ptimer.c
+++ b/hw/core/ptimer.c
@@ -190,6 +190,7 @@ void ptimer_stop(ptimer_state *s)
/* Set counter increment interval in nanoseconds. */
void ptimer_set_period(ptimer_state *s, int64_t period)
{
+ s->delta = ptimer_get_count(s);
s->period = period;
s->period_frac = 0;
if (s->enabled) {
@@ -201,6 +202,7 @@ void ptimer_set_period(ptimer_state *s, int64_t period)
/* Set counter frequency in Hz. */
void ptimer_set_freq(ptimer_state *s, uint32_t freq)
{
+ s->delta = ptimer_get_count(s);
s->period = 1000000000ll / freq;
s->period_frac = (1000000000ll << 32) / freq;
if (s->enabled) {
--
2.8.3
- [Qemu-arm] [PATCH v13 0/8] PTimer fixes/features and ARM MPTimer conversion, Dmitry Osipenko, 2016/05/27
- [Qemu-arm] [PATCH v13 5/8] hw/ptimer: Introduce ptimer_get_limit, Dmitry Osipenko, 2016/05/27
- [Qemu-arm] [PATCH v13 4/8] hw/ptimer: Support "on the fly" timer mode switch, Dmitry Osipenko, 2016/05/27
- [Qemu-arm] [PATCH v13 7/8] hw/ptimer: Fix counter - 1 returned by ptimer_get_count for the active timer, Dmitry Osipenko, 2016/05/27
- [Qemu-arm] [PATCH v13 8/8] arm_mptimer: Convert to use ptimer, Dmitry Osipenko, 2016/05/27
- [Qemu-arm] [PATCH v13 6/8] hw/ptimer: Support running with counter = 0 by introducing new policy feature, Dmitry Osipenko, 2016/05/27
- [Qemu-arm] [PATCH v13 1/8] hw/ptimer: Fix issues caused by the adjusted timer limit value, Dmitry Osipenko, 2016/05/27
- [Qemu-arm] [PATCH v13 2/8] hw/ptimer: Perform counter wrap around if timer already expired, Dmitry Osipenko, 2016/05/27
- [Qemu-arm] [PATCH v13 3/8] hw/ptimer: Update .delta on period/freq change,
Dmitry Osipenko <=