[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 06/10] target-i386: print obsolete warnings if +-f
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-arm] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used |
Date: |
Tue, 7 Jun 2016 14:36:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 07/06/2016 14:32, Igor Mammedov wrote:
>> > Could you detect using +foo together with foo=off, and -foo together
>> > with foo=on? Those are the really problematic cases, without them +foo
>> > and -foo can become synonyms for =on and =off.
> That's (legacy)current semantic of -cpu +-foo where it overrides any foo=x,
> potentially it's possible to track foo=x locally in parser
> and then compare with +-foo both ways.
> But all we can do currently is to print warning about such use case.
>
> I think Eduardo's suggestion to just warn that +-foo is obsolete for now
> and drop support for it in several releases is sufficient(good) enough.
kvm-unit-tests and libvirt both use it, especially because =on and =off
are relatively new I think? It seems like it's really widespread.
Paolo
- [Qemu-arm] [PATCH 02/10] target-i386: cpu: move features logic that requires CPUState to realize time, (continued)
- [Qemu-arm] [PATCH 01/10] target-i386: Remove xlevel & hv-spinlocks option fixups, Igor Mammedov, 2016/06/06
- [Qemu-arm] [PATCH 04/10] target-i386: cpu: use cpu_generic_init() in cpu_x86_init(), Igor Mammedov, 2016/06/06
- [Qemu-arm] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used, Igor Mammedov, 2016/06/06
- Re: [Qemu-arm] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used, Paolo Bonzini, 2016/06/07
- Re: [Qemu-arm] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used, Igor Mammedov, 2016/06/07
- Re: [Qemu-arm] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used,
Paolo Bonzini <=
- Re: [Qemu-arm] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used, Igor Mammedov, 2016/06/07
- Re: [Qemu-arm] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used, Paolo Bonzini, 2016/06/07
- Re: [Qemu-arm] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used, Igor Mammedov, 2016/06/07
- Re: [Qemu-arm] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used, Eduardo Habkost, 2016/06/07
[Qemu-arm] [PATCH 03/10] target-i386: cpu: move xcc->kvm_required check to realize time, Igor Mammedov, 2016/06/06