Re: [Qemu-arm] [PATCH 2/7] target/arm: Split "get pending exception info" from "acknowledge it"

[Peter Maydell]

On 5 February 2018 at 23:44, Philippe Mathieu-Daudé <address@hidden> wrote:
> maybe:
>
> assert(ptargets_secure && pirq);

This is one of those areas where people have different opinions,
but personally I think the point of assertions is to turn
bugs that manifest later and in confusing ways into bugs
that manifest early and clearly. In this case, if either of
those pointers is NULL then we'll immediately segfault in
this function, and the stacktrace will point directly at
the buggy code, so the assert doesn't gain anything.

thanks
-- PMM