Re: [Qemu-arm] [PATCH v1 3/3] raspi: Add "raspi3" machine type

[Peter Maydell]

On 15 February 2018 at 13:14, Philippe Mathieu-Daudé <address@hidden> wrote:
> On 02/15/2018 09:49 AM, Philippe Mathieu-Daudé wrote:
>> On 02/15/2018 09:39 AM, Peter Maydell wrote:
>>> On 8 February 2018 at 05:50, Pekka Enberg <address@hidden> wrote:
>
> Now I remember why I hesitated with this patch,
>
> This part {
>
>>>> +    mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a53");
>>>> +    mc->max_cpus = BCM2836_NCPUS;
>>>> +    mc->min_cpus = BCM2836_NCPUS;
>>>> +    mc->default_cpus = BCM2836_NCPUS;
>
> } is the BCM2837 SoC, very similar to the BCM2836.

Yeah, we had a whole go-around about whether we should have a
BCM2837 object or just make the BCM2836 object have a configurable
CPU type. You could argue either way...

thanks
-- PMM