[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 2/3] hw/sii9022: Add support for Silicon Image SII
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-arm] [PATCH 2/3] hw/sii9022: Add support for Silicon Image SII9022 |
|
Date: |
Tue, 27 Feb 2018 10:09:42 +0000 |
On 27 February 2018 at 07:41, Linus Walleij <address@hidden> wrote:
> On Sat, Feb 17, 2018 at 7:32 PM, Philippe Mathieu-Daudé <address@hidden>
> wrote:
>
>> [Me]
>>> +#define DEBUG_SII9022 0
>>> +
>>> +#define DPRINTF(fmt, ...) \
>>> + do { \
>>> + if (DEBUG_SII9022) { \
>>> + printf("sii9022: " fmt, ## __VA_ARGS__); \
>>> + } \
>>> + } while (0)
>>
>> Can you replace DPRINTF() by trace events?
>
> Absolutely but which ones?
>
> I do not feel senior enough to also invent new trace events
> for displays or I2C devices...
Just put a trace event where you've put DPRINTF debug statements.
thanks
-- PMM
Re: [Qemu-arm] [PATCH 2/3] hw/sii9022: Add support for Silicon Image SII9022, Peter Maydell, 2018/02/22
[Qemu-arm] [PATCH 3/3] arm/vexpress: Add proper display connector emulation, Linus Walleij, 2018/02/17