Re: [Qemu-arm] [PATCH v5 1/7] hw/mdio: Generalize etraxfs MDIO bitbanging emulation

[Philippe Mathieu-Daudé]

Hi Grant,

On 02/27/2018 07:50 PM, Grant Likely wrote:
> On 22/09/2017, 12:13, "Philippe Mathieu-Daudé"
> <address@hidden on behalf of address@hidden> wrote:
>> From: Grant Likely <address@hidden>
>                                   ^^^^^^^^
> 
> Hi Philippe,
> 
> Just following up on this series. I don't really have any additional
> comments. It has been many years since I looked at the code, so I'm
> quite happy for you to have picked it up.

Except Xilinx who uses another approach, nobody in the list seemed
interested. I used your work to run firmwares that are not opensource so
I'm not sure - yet - how to show to the reviewers the usefulness of the
patchset.
I have on my TODO "compare the Xilinx tree with Grant series to see
whichever is more likely to get merged, and search for examples/tests
from the Xilinx wiki".
Since I do this in my free time I have it scheduled to a low priority :(

> 
> However, it is very important for you to preserve the original email
> address that I used when I submitted the patches, and do *not* use my
> arm.com address. None of this code is owned by Arm. Please change the
> From: attribution and my SoB line to use "address@hidden"

Yes, I first thought this domain was not in use anymore but noticed
later this was mistake and was planing to correct it, I apologize for this.

Regards,

Phil.

>>    The etraxfs and Xilinx axienet Ethernet models implement quite a nice
>>    MDIO core that supports both bitbanging and direct register access. This
>>    change factors the common code out into a separate file. There are no
>>    functional changes here, just movement of code.
>>
>>    The etraxfs and axienet are slightly different. The etraxfs version
>>    includes the bitbang state processing, but the axienet version has a
>>    minor enhancement for read/write of phy registers without using bitbang
>>    state variables.  This patch generalizes the etraxfs version, with the
>>    axienet change backported in.
>>
>>    Signed-off-by: Grant Likely <address@hidden>
>>    Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>>    [PMD: rebased with a minor checkpatch fix]