Re: [Qemu-arm] [PATCH v3 6/6] hw/arm/virt: Support -machine gic-version=max

[Peter Maydell]

On 9 March 2018 at 13:50, Alex Bennée <address@hidden> wrote:
>
> Peter Maydell <address@hidden> writes:
>> @@ -1480,9 +1487,11 @@ static void virt_set_gic_version(Object *obj, const 
>> char *value, Error **errp)
>>          vms->gic_version = 2;
>>      } else if (!strcmp(value, "host")) {
>>          vms->gic_version = 0; /* Will probe later */
>> +    } else if (!strcmp(value, "max")) {
>> +        vms->gic_version = -1; /* Will probe later */
>>      } else {
>>          error_setg(errp, "Invalid gic-version value");
>> -        error_append_hint(errp, "Valid values are 3, 2, host.\n");
>> +        error_append_hint(errp, "Valid values are 3, 2, host,
>> max.\n");
>
> nit: host is only valid on aarch64 host. However it will fail later on
> with:
>
>   qemu-system-aarch64: gic-version=host requires KVM

'host' was already in this string. It's valid in the sense that
it's not a syntax error, though it won't work in all situations.
(Similarly, if you try '3' and you have KVM enabled and a gicv2
host system you'll get an error.)

thanks
-- PMM