[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v3 20/22] target/arm: PMU: Add instruction and cyc
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-arm] [PATCH v3 20/22] target/arm: PMU: Add instruction and cycle events |
|
Date: |
Sun, 18 Mar 2018 23:48:22 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03/16/2018 09:31 PM, Aaron Lindsay wrote:
> The instruction event is only enabled when icount is used, cycles are
> always supported. Always defining get_cycle_count (but altering its
> behavior depending on CONFIG_USER_ONLY) allows us to remove some
> CONFIG_USER_ONLY #defines throughout the rest of the code.
>
> Signed-off-by: Aaron Lindsay <address@hidden>
> ---
[...]> #define SUPPORTED_EVENT_SENTINEL UINT16_MAX
> static const pm_event pm_events[] = {
> +#ifndef CONFIG_USER_ONLY
> + { .number = 0x008, /* INST_RETIRED */
"Instruction architecturally executed" seems more explicit to me.
> + .supported = instructions_supported,
> + .get_count = instructions_get_count
> + },
> + { .number = 0x011, /* CPU_CYCLES */
> + .supported = event_always_supported,
> + .get_count = cycles_get_count
> + },
> +#endif
[...]
- Re: [Qemu-arm] [Qemu-devel] [PATCH v3 14/22] target/arm: Make PMOVSCLR 64 bits wide, (continued)
[Qemu-arm] [PATCH v3 12/22] target/arm: Filter cycle counter based on PMCCFILTR_EL0, Aaron Lindsay, 2018/03/16
[Qemu-arm] [PATCH v3 13/22] target/arm: Allow AArch32 access for PMCCFILTR, Aaron Lindsay, 2018/03/16
[Qemu-arm] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions, Aaron Lindsay, 2018/03/16
[Qemu-arm] [PATCH v3 18/22] target/arm: Add array for supported PMU events, generate PMCEID[01], Aaron Lindsay, 2018/03/16
[Qemu-arm] [PATCH v3 17/22] target/arm: Split arm_ccnt_enabled into generic pmu_counter_enabled, Aaron Lindsay, 2018/03/16
[Qemu-arm] [PATCH v3 20/22] target/arm: PMU: Add instruction and cycle events, Aaron Lindsay, 2018/03/16
[Qemu-arm] [PATCH v3 21/22] target/arm: PMU: Set PMCR.N to 4, Aaron Lindsay, 2018/03/16
[Qemu-arm] [PATCH v3 16/22] target/arm: Implement PMOVSSET, Aaron Lindsay, 2018/03/16
[Qemu-arm] [PATCH v3 22/22] target/arm: Implement PMSWINC, Aaron Lindsay, 2018/03/16
[Qemu-arm] [PATCH v3 19/22] target/arm: Finish implementation of PM[X]EVCNTR and PM[X]EVTYPER, Aaron Lindsay, 2018/03/16
Re: [Qemu-arm] [Qemu-devel] [PATCH v3 00/22] More fully implement ARM PMUv3, no-reply, 2018/03/16