|
| From: | Peter Maydell |
| Subject: | Re: [Qemu-arm] [PATCH v2 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR |
| Date: | Tue, 20 Mar 2018 11:22:03 +0000 |
On 20 March 2018 at 07:26, Shannon Zhao <address@hidden> wrote: > While we skip the GIC_INTERNAL irqs, we don't change the register offset > accordingly. This will overlap the GICR registers value and leave the > last GIC_INTERNAL irq's registers out of update. > > Fix this by skipping the registers banked by GICR. > I'm still not entirely sure what the underlying problem you're trying to fix is... Do we fail to correctly migrate a VM without this change? Does the code work on some host CPU/GIC implementations but not others? Is this just improving efficiency by avoiding doing some unnecessary work? thanks -- PMM
| [Prev in Thread] | Current Thread | [Next in Thread] |