[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH V3 1/2] arm_gicv3_kvm: increase clroffset accordin
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH V3 1/2] arm_gicv3_kvm: increase clroffset accordingly |
Date: |
Thu, 24 May 2018 13:38:47 +0100 |
On 23 May 2018 at 04:53, Shannon Zhao <address@hidden> wrote:
> It forgot to increase clroffset during the loop. So it only clear the
> first 4 bytes.
>
> Fixes: 367b9f527becdd20ddf116e17a3c0c2bbc486920
> Cc: address@hidden
> Signed-off-by: Shannon Zhao <address@hidden>
> Reviewed-by: Eric Auger <address@hidden>
> ---
> Changes in V3: Add reviewed-by tag
> ---
> hw/intc/arm_gicv3_kvm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c
> index ec37177..3536795 100644
> --- a/hw/intc/arm_gicv3_kvm.c
> +++ b/hw/intc/arm_gicv3_kvm.c
> @@ -243,6 +243,7 @@ static void kvm_dist_putbmp(GICv3State *s, uint32_t
> offset,
> if (clroffset != 0) {
> reg = 0;
> kvm_gicd_access(s, clroffset, ®, true);
> + clroffset += 4;
> }
> reg = *gic_bmp_ptr32(bmp, irq);
> kvm_gicd_access(s, offset, ®, true);
> --
Applied this patch to target-arm.next.
PS: if you could remember to always provide a cover letter
for multi-patch series that would be helpful.
thanks
-- PMM
- Re: [Qemu-arm] [Qemu-devel] [PATCH V3 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, (continued)
- Re: [Qemu-arm] [Qemu-devel] [PATCH V3 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Auger Eric, 2018/05/24
- Re: [Qemu-arm] [Qemu-devel] [PATCH V3 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Peter Maydell, 2018/05/24
- Re: [Qemu-arm] [Qemu-devel] [PATCH V3 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Auger Eric, 2018/05/24
- Re: [Qemu-arm] [Qemu-devel] [PATCH V3 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Peter Maydell, 2018/05/24
- Re: [Qemu-arm] [Qemu-devel] [PATCH V3 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Peter Maydell, 2018/05/24
- Re: [Qemu-arm] [Qemu-devel] [PATCH V3 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Auger Eric, 2018/05/24
- Re: [Qemu-arm] [Qemu-devel] [PATCH V3 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Shannon Zhao, 2018/05/25
- Re: [Qemu-arm] [Qemu-devel] [PATCH V3 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Peter Maydell, 2018/05/25
Re: [Qemu-arm] [PATCH V3 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Peter Maydell, 2018/05/24
Re: [Qemu-arm] [PATCH V3 1/2] arm_gicv3_kvm: increase clroffset accordingly,
Peter Maydell <=