[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [RISU PATCH v3 05/22] risu: add zlib indication to help t
From: |
Alex Bennée |
Subject: |
Re: [Qemu-arm] [RISU PATCH v3 05/22] risu: add zlib indication to help text |
Date: |
Thu, 14 Jun 2018 09:34:53 +0100 |
User-agent: |
mu4e 1.1.0; emacs 26.1.50 |
Richard Henderson <address@hidden> writes:
> On 06/13/2018 02:55 AM, Alex Bennée wrote:
>> This is a simple aide-memoir as it can be tricky to determine this
>> with a simple statically compiled binary.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>> ---
>> risu.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Eh, sure. Or we could simply require zlib...
>
> Reviewed-by: Richard Henderson <address@hidden>
I would be some cross compilers (or more correctly multiarch setups) are
broken in this regard. There was a time before I moved to 18.04 that I
couldn't have multiple zlib1g-dev packages installed due to clashing
files.
As risu accepts stdin/stdout for trace files you can work around this
with pipes and native gzip so a non-zlib enabled risu is still usable.
But I'm happy to defer to Peter on this one.
--
Alex Bennée
- [Qemu-arm] [RISU PATCH v3 03/22] build-all-arches: expand the range of docker images, (continued)
- [Qemu-arm] [RISU PATCH v3 03/22] build-all-arches: expand the range of docker images, Alex Bennée, 2018/06/13
- [Qemu-arm] [RISU PATCH v3 06/22] Makefile: include risu_reginfo_$(ARCH) in HDRS, Alex Bennée, 2018/06/13
- [Qemu-arm] [RISU PATCH v3 08/22] risugen: Initialize sve predicates with random data, Alex Bennée, 2018/06/13
- [Qemu-arm] [RISU PATCH v3 01/22] risu_reginfo_aarch64: include signal.h for FPSIMD_MAGIC, Alex Bennée, 2018/06/13
- [Qemu-arm] [RISU PATCH v3 07/22] risugen: add --sve support, Alex Bennée, 2018/06/13
- [Qemu-arm] [RISU PATCH v3 05/22] risu: add zlib indication to help text, Alex Bennée, 2018/06/13
- [Qemu-arm] [RISU PATCH v3 04/22] build-all-arches: do a distclean $(SRC) configured, Alex Bennée, 2018/06/13
- [Qemu-arm] [RISU PATCH v3 09/22] risugen: use fewer insns for aarch64 immediate load, Alex Bennée, 2018/06/13
- [Qemu-arm] [RISU PATCH v3 15/22] risu_reginfo_aarch64: drop stray ;, Alex Bennée, 2018/06/13
- [Qemu-arm] [RISU PATCH v3 11/22] risugen: add dtype_msz address helper, Alex Bennée, 2018/06/13
- [Qemu-arm] [RISU PATCH v3 10/22] risugen: add reg_plus_imm_pl and reg_plus_imm_vl address helpers, Alex Bennée, 2018/06/13
- [Qemu-arm] [RISU PATCH v3 17/22] risu_reginfo: introduce reginfo_size(), Alex Bennée, 2018/06/13
- [Qemu-arm] [RISU PATCH v3 18/22] risu_reginfo_aarch64: left justify regnums and drop masks, Alex Bennée, 2018/06/13