[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [RFC v2 15/15] hw/arm/virt: Add nvdimm and nvdimm-persistence
From: |
Eric Auger |
Subject: |
[Qemu-arm] [RFC v2 15/15] hw/arm/virt: Add nvdimm and nvdimm-persistence options |
Date: |
Mon, 2 Jul 2018 19:22:42 +0200 |
Machine option nvdimm allows to turn NVDIMM support on.
Signed-off-by: Eric Auger <address@hidden>
---
hw/arm/virt.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 57 insertions(+), 3 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 51f42cd..13e6dec 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1762,6 +1762,47 @@ static void virt_set_kvm_type(Object *obj, const char
*value, Error **errp)
vms->kvm_type = g_strdup(value);
}
+static bool virt_get_nvdimm(Object *obj, Error **errp)
+{
+ VirtMachineState *vms = VIRT_MACHINE(obj);
+
+ return vms->acpi_nvdimm_state.is_enabled;
+}
+
+static void virt_set_nvdimm(Object *obj, bool value, Error **errp)
+{
+ VirtMachineState *vms = VIRT_MACHINE(obj);
+
+ vms->acpi_nvdimm_state.is_enabled = value;
+}
+
+static char *virt_get_nvdimm_persistence(Object *obj, Error **errp)
+{
+ VirtMachineState *vms = VIRT_MACHINE(obj);
+
+ return g_strdup(vms->acpi_nvdimm_state.persistence_string);
+}
+
+static void virt_set_nvdimm_persistence(Object *obj, const char *value,
+ Error **errp)
+{
+ VirtMachineState *vms = VIRT_MACHINE(obj);
+ AcpiNVDIMMState *nvdimm_state = &vms->acpi_nvdimm_state;
+
+ if (strcmp(value, "cpu") == 0)
+ nvdimm_state->persistence = 3;
+ else if (strcmp(value, "mem-ctrl") == 0)
+ nvdimm_state->persistence = 2;
+ else {
+ error_report("-machine nvdimm-persistence=%s: unsupported option",
+ value);
+ exit(EXIT_FAILURE);
+ }
+
+ g_free(nvdimm_state->persistence_string);
+ nvdimm_state->persistence_string = g_strdup(value);
+}
+
static CpuInstanceProperties
virt_cpu_index_to_props(MachineState *ms, unsigned cpu_index)
{
@@ -1804,10 +1845,10 @@ static void virt_memory_pre_plug(HotplugHandler
*hotplug_dev, DeviceState *dev,
Error **errp)
{
const bool is_nvdimm = object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM);
+ VirtMachineState *vms = VIRT_MACHINE(hotplug_dev);
- if (is_nvdimm) {
- error_setg(errp, "nvdimm is not yet supported");
- return;
+ if (is_nvdimm && !vms->acpi_nvdimm_state.is_enabled) {
+ error_setg(errp, "nvdimm is not enabled: missing 'nvdimm' in '-M'");
}
}
@@ -2044,6 +2085,19 @@ static void virt_3_0_instance_init(Object *obj)
object_property_add_str(obj, "kvm-type",
virt_get_kvm_type, virt_set_kvm_type, NULL);
+ object_property_add_bool(obj, "nvdimm",
+ virt_get_nvdimm, virt_set_nvdimm, NULL);
+ object_property_set_description(obj, "nvdimm",
+ "Set on/off to enable/disable NVDIMM "
+ "instantiation", NULL);
+
+ object_property_add_str(obj, "nvdimm-persistence",
+ virt_get_nvdimm_persistence,
+ virt_set_nvdimm_persistence, NULL);
+ object_property_set_description(obj, "nvdimm-persistence",
+ "Set NVDIMM persistence"
+ "Valid values are cpu and mem-ctrl", NULL);
+
vms->memmap = a15memmap;
vms->irqmap = a15irqmap;
}
--
2.5.5
- [Qemu-arm] [RFC v2 05/15] hw/arm/virt: handle max_vm_phys_shift conflicts on migration, (continued)
- [Qemu-arm] [RFC v2 05/15] hw/arm/virt: handle max_vm_phys_shift conflicts on migration, Eric Auger, 2018/07/02
- [Qemu-arm] [RFC v2 06/15] hw/arm/virt: Allocate device_memory, Eric Auger, 2018/07/02
- [Qemu-arm] [RFC v2 07/15] hw/arm/virt: Add memory hotplug framework, Eric Auger, 2018/07/02
- [Qemu-arm] [RFC v2 08/15] hw/arm/boot: introduce fdt_add_memory_node helper, Eric Auger, 2018/07/02
- [Qemu-arm] [RFC v2 09/15] hw/arm/boot: Expose the PC-DIMM nodes in the DT, Eric Auger, 2018/07/02
- [Qemu-arm] [RFC v2 10/15] acpi: move build_srat_hotpluggable_memory to generic ACPI source, Eric Auger, 2018/07/02
- [Qemu-arm] [RFC v2 11/15] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT, Eric Auger, 2018/07/02
- [Qemu-arm] [RFC v2 12/15] nvdimm: use configurable ACPI IO base and size, Eric Auger, 2018/07/02
- [Qemu-arm] [RFC v2 13/15] hw/arm/virt: Add nvdimm hot-plug infrastructure, Eric Auger, 2018/07/02
- [Qemu-arm] [RFC v2 14/15] hw/arm/boot: Expose the pmem nodes in the DT, Eric Auger, 2018/07/02
- [Qemu-arm] [RFC v2 15/15] hw/arm/virt: Add nvdimm and nvdimm-persistence options,
Eric Auger <=
- Re: [Qemu-arm] [Qemu-devel] [RFC v2 00/15] ARM virt: PCDIMM/NVDIMM at 2TB, no-reply, 2018/07/03