[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH] pvpanic : update pvpanic document
From: |
Andrew Jones |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH] pvpanic : update pvpanic document |
Date: |
Mon, 10 Dec 2018 17:19:34 +0100 |
User-agent: |
NeoMutt/20180716 |
On Thu, Dec 06, 2018 at 07:26:00PM +0800, Peng Hao wrote:
> Add mmio mode as a pci device support info in docs/specs/pvpanic.txt.
>
> Signed-off-by: Peng Hao <address@hidden>
> ---
> docs/specs/pvpanic.txt | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt
> index c7bbacc..6d62d72 100644
> --- a/docs/specs/pvpanic.txt
> +++ b/docs/specs/pvpanic.txt
> @@ -1,7 +1,7 @@
> PVPANIC DEVICE
> ==============
>
> -pvpanic device is a simulated ISA device, through which a guest panic
> +pvpanic device is a simulated device, through which a guest panic
> event is sent to qemu, and a QMP event is generated. This allows
> management apps (e.g. libvirt) to be notified and respond to the event.
>
> @@ -9,6 +9,10 @@ The management app has the option of waiting for
> GUEST_PANICKED events,
> and/or polling for guest-panicked RunState, to learn when the pvpanic
> device has fired a panic event.
>
> +The pvpanic device can be implemented as an ISA device (using IOPORT),
> +or, since qemu 4.0, as a PCI device (using MMIO address space of pci
> +device).
I'd drop the part in (). Just end with 'as a PCI device.' The MMIO stuff
is described below in the "PCI Interface" section.
> +
> ISA Interface
> -------------
>
> @@ -19,6 +23,13 @@ Software should set only bits both itself and the device
> recognize.
> Currently, only bit 0 is recognized, setting it indicates a guest panic
> has happened.
>
> +PCI Interface
> +-------------
> +
> +The PCI interface is similar to the ISA interface except that it uses
> +MMIO.
uses an MMIO address space provided by its BAR0.
Should describe that the MMIO address is two bytes in size here as well.
> For example, the arm virt machine could enable pvpanic-pci device
> +according to adding "-device pvpanic-pci" in qemu command.
For example, the arm virt machine may enable a pvpanic device by
adding '-device pvpanic-pci' to the command line.
> +
> ACPI Interface
> --------------
>
> --
> 1.8.3.1
>
>
Thanks,
drew
- [Qemu-arm] [PATCH V12 0/5] add pvpanic mmio support, Peng Hao, 2018/12/06
- [Qemu-arm] [PATCH V12 4/5] hw/arm/virt: Use the pvpanic pci device, Peng Hao, 2018/12/06
- [Qemu-arm] [PATCH V12 2/5] hw/misc/pvpanic: Cosmetic renaming, Peng Hao, 2018/12/06
- [Qemu-arm] [PATCH V12 3/5] hw/misc/pvpanic: Add the PCI interface, Peng Hao, 2018/12/06
- [Qemu-arm] [PATCH V12 1/5] hw/misc/pvpanic: Build the pvpanic device in $(common-obj), Peng Hao, 2018/12/06
- [Qemu-arm] [PATCH] pvpanic : update pvpanic document, Peng Hao, 2018/12/06
- Re: [Qemu-arm] [Qemu-devel] [PATCH] pvpanic : update pvpanic document,
Andrew Jones <=
- Re: [Qemu-arm] [PATCH V12 0/5] add pvpanic mmio support, peng.hao2, 2018/12/08
- Re: [Qemu-arm] [Qemu-devel] [PATCH V12 0/5] add pvpanic mmio support, Andrew Jones, 2018/12/10